Re: [PATCH net-next v2 1/9] ptp: introduce programmable pins.

2014-03-20 Thread David Miller
From: Richard Cochran Date: Thu, 20 Mar 2014 21:43:08 +0100 > On Mon, Mar 17, 2014 at 09:25:34PM -0400, David Miller wrote: >> >> This locking seems unnecessarily complex to me. You should be able to >> do the stateless sanity checks, take the mutex, then do all of the >> rest of the operations

Re: [PATCH net-next v2 1/9] ptp: introduce programmable pins.

2014-03-20 Thread Richard Cochran
On Mon, Mar 17, 2014 at 09:25:34PM -0400, David Miller wrote: > > This locking seems unnecessarily complex to me. You should be able to > do the stateless sanity checks, take the mutex, then do all of the > rest of the operations until the end of the function before > dropping the lock. > > So j

Re: [PATCH net-next v2 1/9] ptp: introduce programmable pins.

2014-03-17 Thread David Miller
From: Richard Cochran Date: Sun, 16 Mar 2014 14:29:22 +0100 > + /* Check to see if any other pin previously had this function. */ > + if (mutex_lock_interruptible(&ptp->pincfg_mux)) > + return -ERESTARTSYS; > + for (i = 0; i < info->n_pins; i++) { > + if (info-

[PATCH net-next v2 1/9] ptp: introduce programmable pins.

2014-03-16 Thread Richard Cochran
This patch adds a pair of new ioctls to the PTP Hardware Clock device interface. Using the ioctls, user space programs can query each pin to find out its current function and also reprogram a different function if desired. Signed-off-by: Richard Cochran --- drivers/ptp/ptp_chardev.c| 13