Re: [PATCH net-next v2 1/3] net/usb/r8152: support aggregation

2013-08-15 Thread Francois Romieu
hayeswang : > Francois Romieu [mailto:rom...@fr.zoreil.com] [...] > > The forward declaration is not needed. > > The r8152_submit_rx() need the declaration of read_bulk_callback(), and the > read_bulk_callback() need the declaration of r8152_submit_rx(), too. It likes > a dead lock, so I have no

RE: [PATCH net-next v2 1/3] net/usb/r8152: support aggregation

2013-08-15 Thread hayeswang
Francois Romieu [mailto:rom...@fr.zoreil.com] > Sent: Thursday, August 15, 2013 8:26 PM > To: Hayeswang > Cc: net...@vger.kernel.org; nic_swsd; > linux-kernel@vger.kernel.org; linux-...@vger.kernel.org; David Miller > Subject: Re: [PATCH net-next v2 1/3] net/usb/r8152: support

Re: [PATCH net-next v2 1/3] net/usb/r8152: support aggregation

2013-08-15 Thread Francois Romieu
Hayes Wang : [...] > diff --git a/drivers/net/usb/r8152.c b/drivers/net/usb/r8152.c > index 11c51f2..abb0b9f 100644 > --- a/drivers/net/usb/r8152.c > +++ b/drivers/net/usb/r8152.c [...] > @@ -315,13 +318,34 @@ struct tx_desc { > u32 opts2; > }; > > +struct rx_agg { > + struct list_hea

Re: [PATCH net-next v2 1/3] net/usb/r8152: support aggregation

2013-08-15 Thread David Miller
From: Hayes Wang Date: Wed, 14 Aug 2013 20:54:38 +0800 > Enable the tx/rx aggregation which could contain one or more packets > for each bulk in/out. This could reduce the loading of the host > controller by sending less bulk transfer. > > The rx packets in the bulk in buffer should be 8-byte al

[PATCH net-next v2 1/3] net/usb/r8152: support aggregation

2013-08-14 Thread Hayes Wang
Enable the tx/rx aggregation which could contain one or more packets for each bulk in/out. This could reduce the loading of the host controller by sending less bulk transfer. The rx packets in the bulk in buffer should be 8-byte aligned, and the tx packets in the bulk out buffer should be 4-byte a