Re: [PATCH net-next v2] net: bcmgenet: Generate a random MAC if none is valid

2019-10-15 Thread David Miller
From: Florian Fainelli Date: Mon, 14 Oct 2019 14:20:00 -0700 > Instead of having a hard failure and stopping the driver's probe > routine, generate a random Ethernet MAC address to keep going. > > Signed-off-by: Florian Fainelli Applied to net-next, thank you.

Re: [PATCH net-next v2] net: bcmgenet: Generate a random MAC if none is valid

2019-10-15 Thread David Miller
From: Jakub Kicinski Date: Tue, 15 Oct 2019 15:39:55 -0700 > On Tue, 15 Oct 2019 15:32:28 -0700, Scott Branden wrote: >> > @@ -3482,7 +3476,12 @@ static int bcmgenet_probe(struct platform_device >> > *pdev) >> > >> >SET_NETDEV_DEV(dev, &pdev->dev); >> >dev_set_drvdata(&pdev->dev, dev)

Re: [PATCH net-next v2] net: bcmgenet: Generate a random MAC if none is valid

2019-10-15 Thread Jakub Kicinski
On Tue, 15 Oct 2019 15:32:28 -0700, Scott Branden wrote: > > @@ -3482,7 +3476,12 @@ static int bcmgenet_probe(struct platform_device > > *pdev) > > > > SET_NETDEV_DEV(dev, &pdev->dev); > > dev_set_drvdata(&pdev->dev, dev); > > - ether_addr_copy(dev->dev_addr, macaddr); > > + if (IS_

Re: [PATCH net-next v2] net: bcmgenet: Generate a random MAC if none is valid

2019-10-15 Thread Scott Branden
Hi Florian, On 2019-10-14 2:20 p.m., Florian Fainelli wrote: Instead of having a hard failure and stopping the driver's probe routine, generate a random Ethernet MAC address to keep going. Signed-off-by: Florian Fainelli --- Changes in v2: - provide a message that a random MAC is used, the sa

Re: [PATCH net-next v2] net: bcmgenet: Generate a random MAC if none is valid

2019-10-14 Thread Doug Berger
On 10/14/19 2:20 PM, Florian Fainelli wrote: > Instead of having a hard failure and stopping the driver's probe > routine, generate a random Ethernet MAC address to keep going. > > Signed-off-by: Florian Fainelli > --- > Changes in v2: > > - provide a message that a random MAC is used, the same

[PATCH net-next v2] net: bcmgenet: Generate a random MAC if none is valid

2019-10-14 Thread Florian Fainelli
Instead of having a hard failure and stopping the driver's probe routine, generate a random Ethernet MAC address to keep going. Signed-off-by: Florian Fainelli --- Changes in v2: - provide a message that a random MAC is used, the same message that bcmsysport.c uses drivers/net/ethernet/broad