Re: [PATCH net-next v19 00/26] Introducing OpenVPN Data Channel Offload

2025-02-14 Thread Antonio Quartulli
On 14/02/2025 14:54, Antonio Quartulli wrote: For example in wireguard/device.c the socket is released in pernet_operations.pre_exit(). But pre_exit() is invoked in cleanup_net(), which is invoked ONLY if the net refcount has reached 0...but how can it be zero before the sockets have been rel

Re: [PATCH net-next v19 00/26] Introducing OpenVPN Data Channel Offload

2025-02-14 Thread Antonio Quartulli
On 13/02/2025 20:40, Antonio Quartulli wrote: On 13/02/2025 16:46, Sabrina Dubroca wrote: 2025-02-13, 12:46:34 +0100, Antonio Quartulli wrote: On 13/02/2025 00:34, Sabrina Dubroca wrote: Hello, 2025-02-11, 01:39:53 +0100, Antonio Quartulli wrote: All minor and major reported problems have be

Re: [PATCH net-next v19 00/26] Introducing OpenVPN Data Channel Offload

2025-02-13 Thread Antonio Quartulli
On 13/02/2025 16:46, Sabrina Dubroca wrote: 2025-02-13, 12:46:34 +0100, Antonio Quartulli wrote: On 13/02/2025 00:34, Sabrina Dubroca wrote: Hello, 2025-02-11, 01:39:53 +0100, Antonio Quartulli wrote: All minor and major reported problems have been finally addressed. Big thanks to Sabrina, wh

Re: [PATCH net-next v19 00/26] Introducing OpenVPN Data Channel Offload

2025-02-13 Thread Antonio Quartulli
Hi Sean, On 13/02/2025 15:26, Sean Anderson wrote: Hi Antonio, On 2/10/25 19:39, Antonio Quartulli wrote: NOTE: TCP tests are still showing the following warning while running iperf. I have analysed the report several times, but it definitely looks like a false positive to me, so nothing to wo

Re: [PATCH net-next v19 00/26] Introducing OpenVPN Data Channel Offload

2025-02-13 Thread Sabrina Dubroca
2025-02-13, 12:46:34 +0100, Antonio Quartulli wrote: > On 13/02/2025 00:34, Sabrina Dubroca wrote: > > Hello, > > > > 2025-02-11, 01:39:53 +0100, Antonio Quartulli wrote: > > > All minor and major reported problems have been finally addressed. > > > Big thanks to Sabrina, who took the time to guid

Re: [PATCH net-next v19 00/26] Introducing OpenVPN Data Channel Offload

2025-02-13 Thread Sean Anderson
Hi Antonio, On 2/10/25 19:39, Antonio Quartulli wrote: NOTE: TCP tests are still showing the following warning while running iperf. I have analysed the report several times, but it definitely looks like a false positive to me, so nothing to worry about. Basically the lockdep engine gets confuse

Re: [PATCH net-next v19 00/26] Introducing OpenVPN Data Channel Offload

2025-02-13 Thread Antonio Quartulli
On 13/02/2025 00:34, Sabrina Dubroca wrote: Hello, 2025-02-11, 01:39:53 +0100, Antonio Quartulli wrote: All minor and major reported problems have been finally addressed. Big thanks to Sabrina, who took the time to guide me through converting the peer socket to an RCU pointer. Something is of

Re: [PATCH net-next v19 00/26] Introducing OpenVPN Data Channel Offload

2025-02-12 Thread Sabrina Dubroca
Hello, 2025-02-11, 01:39:53 +0100, Antonio Quartulli wrote: > All minor and major reported problems have been finally addressed. > Big thanks to Sabrina, who took the time to guide me through > converting the peer socket to an RCU pointer. Something is off (not sure if it's new to this version):

[PATCH net-next v19 00/26] Introducing OpenVPN Data Channel Offload

2025-02-10 Thread Antonio Quartulli
All minor and major reported problems have been finally addressed. Big thanks to Sabrina, who took the time to guide me through converting the peer socket to an RCU pointer. This patchset comes with an extra patch for .mailmap to remove my @openvpn.net address from the file, otherwise git won't al