Re: [PATCH net-next v11 08/23] ovpn: implement basic TX path (UDP)

2024-11-21 Thread Antonio Quartulli
On 20/11/2024 12:45, Sabrina Dubroca wrote: 2024-10-29, 11:47:21 +0100, Antonio Quartulli wrote: +static int ovpn_udp4_output(struct ovpn_struct *ovpn, struct ovpn_bind *bind, + struct dst_cache *cache, struct sock *sk, + struct sk_buff *skb) +

Re: [PATCH net-next v11 08/23] ovpn: implement basic TX path (UDP)

2024-11-21 Thread Antonio Quartulli
On 21/11/2024 01:29, Sergey Ryazanov wrote: On 15.11.2024 16:39, Antonio Quartulli wrote: On 11/11/2024 00:54, Sergey Ryazanov wrote: Another one forgotten question, sorry about this. Please find the question inlined. On 29.10.2024 12:47, Antonio Quartulli wrote:   /* Send user data to the n

Re: [PATCH net-next v11 08/23] ovpn: implement basic TX path (UDP)

2024-11-20 Thread Sergey Ryazanov
On 15.11.2024 16:39, Antonio Quartulli wrote: On 11/11/2024 00:54, Sergey Ryazanov wrote: Another one forgotten question, sorry about this. Please find the question inlined. On 29.10.2024 12:47, Antonio Quartulli wrote:   /* Send user data to the network    */   netdev_tx_t ovpn_net_xmit(stru

Re: [PATCH net-next v11 08/23] ovpn: implement basic TX path (UDP)

2024-11-20 Thread Sabrina Dubroca
2024-10-29, 11:47:21 +0100, Antonio Quartulli wrote: > +static int ovpn_udp4_output(struct ovpn_struct *ovpn, struct ovpn_bind *bind, > + struct dst_cache *cache, struct sock *sk, > + struct sk_buff *skb) > +{ [...] > + if (unlikely(!inet_confirm_

Re: [PATCH net-next v11 08/23] ovpn: implement basic TX path (UDP)

2024-11-15 Thread Antonio Quartulli
On 11/11/2024 00:54, Sergey Ryazanov wrote: Another one forgotten question, sorry about this. Please find the question inlined. On 29.10.2024 12:47, Antonio Quartulli wrote:   /* Send user data to the network    */   netdev_tx_t ovpn_net_xmit(struct sk_buff *skb, struct net_device *dev)   { + 

Re: [PATCH net-next v11 08/23] ovpn: implement basic TX path (UDP)

2024-11-14 Thread Antonio Quartulli
On 10/11/2024 23:32, Sergey Ryazanov wrote: [...] +/* send skb to connected peer, if any */ +static void ovpn_send(struct ovpn_struct *ovpn, struct sk_buff *skb, +  struct ovpn_peer *peer) +{ +    struct sk_buff *curr, *next; + +    if (likely(!peer)) +    /* retrieve peer serving

Re: [PATCH net-next v11 08/23] ovpn: implement basic TX path (UDP)

2024-11-12 Thread Sabrina Dubroca
2024-11-11, 00:32:51 +0200, Sergey Ryazanov wrote: > On 29.10.2024 12:47, Antonio Quartulli wrote: > > +static void ovpn_encrypt_post(struct sk_buff *skb, int ret) > > +{ > > + struct ovpn_peer *peer = ovpn_skb_cb(skb)->peer; > > + > > + if (unlikely(ret < 0)) > > + goto err; > > + >

Re: [PATCH net-next v11 08/23] ovpn: implement basic TX path (UDP)

2024-11-10 Thread Sergey Ryazanov
Another one forgotten question, sorry about this. Please find the question inlined. On 29.10.2024 12:47, Antonio Quartulli wrote: /* Send user data to the network */ netdev_tx_t ovpn_net_xmit(struct sk_buff *skb, struct net_device *dev) { + struct ovpn_struct *ovpn = netdev_priv(

Re: [PATCH net-next v11 08/23] ovpn: implement basic TX path (UDP)

2024-11-10 Thread Sergey Ryazanov
On 29.10.2024 12:47, Antonio Quartulli wrote: Packets sent over the ovpn interface are processed and transmitted to the connected peer, if any. Implementation is UDP only. TCP will be added by a later patch. Note: no crypto/encapsulation exists yet. packets are just captured and sent. Signed-o

Re: [PATCH net-next v11 08/23] ovpn: implement basic TX path (UDP)

2024-10-30 Thread Antonio Quartulli
On 30/10/2024 18:14, Sabrina Dubroca wrote: 2024-10-29, 11:47:21 +0100, Antonio Quartulli wrote: +static void ovpn_send(struct ovpn_struct *ovpn, struct sk_buff *skb, + struct ovpn_peer *peer) +{ + struct sk_buff *curr, *next; + + if (likely(!peer)) +

Re: [PATCH net-next v11 08/23] ovpn: implement basic TX path (UDP)

2024-10-30 Thread Sabrina Dubroca
2024-10-29, 11:47:21 +0100, Antonio Quartulli wrote: > +static void ovpn_send(struct ovpn_struct *ovpn, struct sk_buff *skb, > + struct ovpn_peer *peer) > +{ > + struct sk_buff *curr, *next; > + > + if (likely(!peer)) > + /* retrieve peer serving the destinatio

[PATCH net-next v11 08/23] ovpn: implement basic TX path (UDP)

2024-10-29 Thread Antonio Quartulli
Packets sent over the ovpn interface are processed and transmitted to the connected peer, if any. Implementation is UDP only. TCP will be added by a later patch. Note: no crypto/encapsulation exists yet. packets are just captured and sent. Signed-off-by: Antonio Quartulli --- drivers/net/ovpn/