Re: [PATCH net-next V6 2/2] net/mlx4_en: Use affinity hint

2014-06-02 Thread Amir Vadai
On 6/2/2014 8:13 AM, Eric Dumazet wrote: On Sun, 2014-06-01 at 21:56 -0700, David Miller wrote: Indeed you have to provide a dummy version for a non-SMP build etc. I'm reverting. Hi David. I think your revert took one wrong commit. # git show ee39facbf82e73e468c504d2b40e83e2d223c28c | dif

Re: [PATCH net-next V6 2/2] net/mlx4_en: Use affinity hint

2014-06-02 Thread David Miller
From: Eric Dumazet Date: Sun, 01 Jun 2014 22:13:12 -0700 > On Sun, 2014-06-01 at 21:56 -0700, David Miller wrote: > >> Indeed you have to provide a dummy version for a non-SMP build etc. >> >> I'm reverting. >> > > Hi David. I think your revert took one wrong commit. Thanks I'll fix it up. -

Re: [PATCH net-next V6 2/2] net/mlx4_en: Use affinity hint

2014-06-01 Thread Eric Dumazet
On Sun, 2014-06-01 at 21:56 -0700, David Miller wrote: > Indeed you have to provide a dummy version for a non-SMP build etc. > > I'm reverting. > Hi David. I think your revert took one wrong commit. # git show ee39facbf82e73e468c504d2b40e83e2d223c28c | diffstat -p1 -w70 drivers/net/ethernet/

Re: [PATCH net-next V6 2/2] net/mlx4_en: Use affinity hint

2014-06-01 Thread David Miller
From: Eric Dumazet Date: Sun, 01 Jun 2014 21:37:11 -0700 > On Sun, 2014-06-01 at 21:16 -0700, Eric Dumazet wrote: >> CC [M] drivers/net/ethernet/mellanox/mlx4/en_netdev.o >> drivers/net/ethernet/mellanox/mlx4/en_netdev.c: In function >> ‘mlx4_en_init_affinity_hint’: >> drivers/net/ethernet/me

Re: [PATCH net-next V6 2/2] net/mlx4_en: Use affinity hint

2014-06-01 Thread David Miller
From: Eric Dumazet Date: Sun, 01 Jun 2014 21:16:50 -0700 > CC [M] drivers/net/ethernet/mellanox/mlx4/en_netdev.o > drivers/net/ethernet/mellanox/mlx4/en_netdev.c: In function > ‘mlx4_en_init_affinity_hint’: > drivers/net/ethernet/mellanox/mlx4/en_netdev.c:1546:23: error: incompatible > types

Re: [PATCH net-next V6 2/2] net/mlx4_en: Use affinity hint

2014-06-01 Thread Eric Dumazet
On Sun, 2014-06-01 at 21:16 -0700, Eric Dumazet wrote: > On Sun, 2014-05-25 at 17:47 +0300, Amir Vadai wrote: > > From: Yuval Atias > > > > The “affinity hint” mechanism is used by the user space > > daemon, irqbalancer, to indicate a preferred CPU mask for irqs. > > Irqbalancer can use this hint

Re: [PATCH net-next V6 2/2] net/mlx4_en: Use affinity hint

2014-06-01 Thread Eric Dumazet
On Sun, 2014-05-25 at 17:47 +0300, Amir Vadai wrote: > From: Yuval Atias > > The “affinity hint” mechanism is used by the user space > daemon, irqbalancer, to indicate a preferred CPU mask for irqs. > Irqbalancer can use this hint to balance the irqs between the > cpus indicated by the mask. > >

[PATCH net-next V6 2/2] net/mlx4_en: Use affinity hint

2014-05-25 Thread Amir Vadai
From: Yuval Atias The “affinity hint” mechanism is used by the user space daemon, irqbalancer, to indicate a preferred CPU mask for irqs. Irqbalancer can use this hint to balance the irqs between the cpus indicated by the mask. We wish the HCA to preferentially map the IRQs it uses to numa cores