Re: [PATCH net-next 4/5] net: dsa: lan9303: Remove unnecessary parentheses

2017-11-06 Thread Egil Hjelmeland
On 03. nov. 2017 15:54, Vivien Didelot wrote: Hi Egil, Egil Hjelmeland writes: If you send a v2, you may want to address the other parenthesis alignment issues found when running ./scripts/checkpatch -f on the lan9303* files. There is just one remaining alignment issue. Removing that would

Re: [PATCH net-next 4/5] net: dsa: lan9303: Remove unnecessary parentheses

2017-11-06 Thread Egil Hjelmeland
On 03. nov. 2017 15:35, Egil Hjelmeland wrote: On 03. nov. 2017 15:11, Joe Perches wrote: On Fri, 2017-11-03 at 11:55 +0100, Egil Hjelmeland wrote: Remove scripts/checkpatch.pl CHECKs by remove unnecessary parentheses [] diff --git a/drivers/net/dsa/lan9303-core.c b/drivers/net/dsa/lan9303-co

Re: [PATCH net-next 4/5] net: dsa: lan9303: Remove unnecessary parentheses

2017-11-03 Thread Vivien Didelot
Hi Egil, Egil Hjelmeland writes: > If there are no disagreements, I can do a v2 with that. > > And thanks for teaching me about "git grep"! If you send a v2, you may want to address the other parenthesis alignment issues found when running ./scripts/checkpatch -f on the lan9303* files. Applyin

Re: [PATCH net-next 4/5] net: dsa: lan9303: Remove unnecessary parentheses

2017-11-03 Thread Egil Hjelmeland
On 03. nov. 2017 15:11, Joe Perches wrote: On Fri, 2017-11-03 at 11:55 +0100, Egil Hjelmeland wrote: Remove scripts/checkpatch.pl CHECKs by remove unnecessary parentheses [] diff --git a/drivers/net/dsa/lan9303-core.c b/drivers/net/dsa/lan9303-core.c [] @@ -483,7 +483,7 @@ static int lan9303

Re: [PATCH net-next 4/5] net: dsa: lan9303: Remove unnecessary parentheses

2017-11-03 Thread Joe Perches
On Fri, 2017-11-03 at 11:55 +0100, Egil Hjelmeland wrote: > Remove scripts/checkpatch.pl CHECKs by remove unnecessary parentheses [] > diff --git a/drivers/net/dsa/lan9303-core.c b/drivers/net/dsa/lan9303-core.c [] > @@ -483,7 +483,7 @@ static int lan9303_detect_phy_setup(struct lan9303 *chip) >

[PATCH net-next 4/5] net: dsa: lan9303: Remove unnecessary parentheses

2017-11-03 Thread Egil Hjelmeland
Remove scripts/checkpatch.pl CHECKs by remove unnecessary parentheses Signed-off-by: Egil Hjelmeland --- drivers/net/dsa/lan9303-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/dsa/lan9303-core.c b/drivers/net/dsa/lan9303-core.c index 70ecd18a5e7d..b9a95f54