Re: [PATCH net-next 2/3] net: ethernet: socionext: add AVE ethernet driver

2017-09-21 Thread Kunihiko Hayashi
On Mon, 11 Sep 2017 15:55:56 +0900 wrote: > > > +static int ave_set_rxdesc(struct net_device *ndev, int entry) > > > +{ > > > + struct ave_private *priv = netdev_priv(ndev); > > > + struct sk_buff *skb; > > > + unsigned long align; > > > + dma_addr_t paddr; > > > + void *buffptr; > > > + int ret

Re: [PATCH net-next 2/3] net: ethernet: socionext: add AVE ethernet driver

2017-09-12 Thread Kunihiko Hayashi
Hi Andrew, On Mon, 11 Sep 2017 14:00:09 +0200 Andrew Lunn wrote: > > > > +static irqreturn_t ave_interrupt(int irq, void *netdev) > > > > +{ > > > > + struct net_device *ndev = (struct net_device *)netdev; > > > > + struct ave_private *priv = netdev_priv(ndev); > > > > + u32 gi

Re: [PATCH net-next 2/3] net: ethernet: socionext: add AVE ethernet driver

2017-09-11 Thread Andrew Lunn
> > > +static irqreturn_t ave_interrupt(int irq, void *netdev) > > > +{ > > > + struct net_device *ndev = (struct net_device *)netdev; > > > + struct ave_private *priv = netdev_priv(ndev); > > > + u32 gimr_val, gisr_val; > > > + > > > + gimr_val = ave_irq_disable_all(ndev); > > > + > > > + /* get i

Re: [PATCH net-next 2/3] net: ethernet: socionext: add AVE ethernet driver

2017-09-10 Thread Kunihiko Hayashi
Hi Florian, On Sat, 9 Sep 2017 09:30:58 -0700 wrote: > > > On 09/08/2017 06:02 AM, Kunihiko Hayashi wrote: > > The UniPhier platform from Socionext provides the AVE ethernet > > controller that includes MAC and MDIO bus supporting RGMII/RMII > > modes. The controller is named AVE. > > > > Sig

Re: [PATCH net-next 2/3] net: ethernet: socionext: add AVE ethernet driver

2017-09-10 Thread Kunihiko Hayashi
Hi Florian, Thank you for your comments, On Fri, 8 Sep 2017 12:31:18 -0700 wrote: > On 09/08/2017 06:02 AM, Kunihiko Hayashi wrote: > > The UniPhier platform from Socionext provides the AVE ethernet > > controller that includes MAC and MDIO bus supporting RGMII/RMII > > modes. The controller is

Re: [PATCH net-next 2/3] net: ethernet: socionext: add AVE ethernet driver

2017-09-10 Thread Kunihiko Hayashi
Hi Yamada-san, Thank you for your comments, On Fri, 8 Sep 2017 23:44:13 +0900 wrote: > 2017-09-08 22:02 GMT+09:00 Kunihiko Hayashi : > > > diff --git a/drivers/net/ethernet/socionext/Kconfig > > b/drivers/net/ethernet/socionext/Kconfig > > new file mode 100644 > > index 000..788f26f > > --

Re: [PATCH net-next 2/3] net: ethernet: socionext: add AVE ethernet driver

2017-09-10 Thread Kunihiko Hayashi
Hi Andrew, Thank you for your comments. On Fri, 8 Sep 2017 15:50:30 +0200 wrote: > > +static int ave_mdio_busywait(struct net_device *ndev) > > +{ > > + int ret = 1, loop = 100; > > + u32 mdiosr; > > + > > + /* wait until completion */ > > + while (1) { > > + mdiosr = ave_r32(n

Re: [PATCH net-next 2/3] net: ethernet: socionext: add AVE ethernet driver

2017-09-09 Thread Florian Fainelli
On 09/08/2017 06:02 AM, Kunihiko Hayashi wrote: > The UniPhier platform from Socionext provides the AVE ethernet > controller that includes MAC and MDIO bus supporting RGMII/RMII > modes. The controller is named AVE. > > Signed-off-by: Kunihiko Hayashi > Signed-off-by: Jassi Brar > --- [snip]

Re: [PATCH net-next 2/3] net: ethernet: socionext: add AVE ethernet driver

2017-09-08 Thread Florian Fainelli
On 09/08/2017 06:02 AM, Kunihiko Hayashi wrote: > The UniPhier platform from Socionext provides the AVE ethernet > controller that includes MAC and MDIO bus supporting RGMII/RMII > modes. The controller is named AVE. > > Signed-off-by: Kunihiko Hayashi > Signed-off-by: Jassi Brar > --- > driver

Re: [PATCH net-next 2/3] net: ethernet: socionext: add AVE ethernet driver

2017-09-08 Thread Masahiro Yamada
2017-09-08 22:02 GMT+09:00 Kunihiko Hayashi : > diff --git a/drivers/net/ethernet/socionext/Kconfig > b/drivers/net/ethernet/socionext/Kconfig > new file mode 100644 > index 000..788f26f > --- /dev/null > +++ b/drivers/net/ethernet/socionext/Kconfig > @@ -0,0 +1,22 @@ > +config NET_VENDOR_SOC

Re: [PATCH net-next 2/3] net: ethernet: socionext: add AVE ethernet driver

2017-09-08 Thread Andrew Lunn
> +static int ave_mdio_busywait(struct net_device *ndev) > +{ > + int ret = 1, loop = 100; > + u32 mdiosr; > + > + /* wait until completion */ > + while (1) { > + mdiosr = ave_r32(ndev, AVE_MDIOSR); > + if (!(mdiosr & AVE_MDIOSR_STS)) > +

[PATCH net-next 2/3] net: ethernet: socionext: add AVE ethernet driver

2017-09-08 Thread Kunihiko Hayashi
The UniPhier platform from Socionext provides the AVE ethernet controller that includes MAC and MDIO bus supporting RGMII/RMII modes. The controller is named AVE. Signed-off-by: Kunihiko Hayashi Signed-off-by: Jassi Brar --- drivers/net/ethernet/Kconfig |1 + drivers/net/etherne