Re: [PATCH net-next 1/2] soc: qcom: ipa: Constify static qmi structs

2020-11-25 Thread Jakub Kicinski
On Wed, 25 Nov 2020 15:45:05 -0600 Alex Elder wrote: > On 11/22/20 5:40 PM, Rikard Falkeborn wrote: > > These are only used as input arguments to qmi_handle_init() which > > accepts const pointers to both qmi_ops and qmi_msg_handler. Make them > > const to allow the compiler to put them in read-onl

Re: [PATCH net-next 1/2] soc: qcom: ipa: Constify static qmi structs

2020-11-25 Thread Alex Elder
On 11/22/20 5:40 PM, Rikard Falkeborn wrote: These are only used as input arguments to qmi_handle_init() which accepts const pointers to both qmi_ops and qmi_msg_handler. Make them const to allow the compiler to put them in read-only memory. Signed-off-by: Rikard Falkeborn Good idea. Thanks

Re: [PATCH net-next 1/2] soc: qcom: ipa: Constify static qmi structs

2020-11-24 Thread Kalle Valo
Jakub Kicinski writes: > On Mon, 23 Nov 2020 00:40:30 +0100 Rikard Falkeborn wrote: >> These are only used as input arguments to qmi_handle_init() which >> accepts const pointers to both qmi_ops and qmi_msg_handler. Make them >> const to allow the compiler to put them in read-only memory. >> >>

Re: [PATCH net-next 1/2] soc: qcom: ipa: Constify static qmi structs

2020-11-24 Thread Jakub Kicinski
On Mon, 23 Nov 2020 00:40:30 +0100 Rikard Falkeborn wrote: > These are only used as input arguments to qmi_handle_init() which > accepts const pointers to both qmi_ops and qmi_msg_handler. Make them > const to allow the compiler to put them in read-only memory. > > Signed-off-by: Rikard Falkeborn

[PATCH net-next 1/2] soc: qcom: ipa: Constify static qmi structs

2020-11-22 Thread Rikard Falkeborn
These are only used as input arguments to qmi_handle_init() which accepts const pointers to both qmi_ops and qmi_msg_handler. Make them const to allow the compiler to put them in read-only memory. Signed-off-by: Rikard Falkeborn --- drivers/net/ipa/ipa_qmi.c | 8 1 file changed, 4 inser