Re: [PATCH net-next 02/12] net: phy: bcm7xxx: add support for 28nm EPHY

2017-03-14 Thread Doug Berger
On 03/13/2017 07:43 PM, Andrew Lunn wrote: > On Mon, Mar 13, 2017 at 07:06:25PM -0700, Doug Berger wrote: >> On 03/13/2017 06:06 PM, Andrew Lunn wrote: >>> On Mon, Mar 13, 2017 at 05:41:32PM -0700, Doug Berger wrote: +static int bcm7xxx_28nm_ephy_01_afe_config_init(struct phy_device *phydev) >

Re: [PATCH net-next 02/12] net: phy: bcm7xxx: add support for 28nm EPHY

2017-03-13 Thread Andrew Lunn
On Mon, Mar 13, 2017 at 07:06:25PM -0700, Doug Berger wrote: > On 03/13/2017 06:06 PM, Andrew Lunn wrote: > > On Mon, Mar 13, 2017 at 05:41:32PM -0700, Doug Berger wrote: > >> +static int bcm7xxx_28nm_ephy_01_afe_config_init(struct phy_device *phydev) > >> +{ > >> + int ret; > >> + > >> + /* set

Re: [PATCH net-next 02/12] net: phy: bcm7xxx: add support for 28nm EPHY

2017-03-13 Thread Doug Berger
On 03/13/2017 06:06 PM, Andrew Lunn wrote: > On Mon, Mar 13, 2017 at 05:41:32PM -0700, Doug Berger wrote: >> +static int bcm7xxx_28nm_ephy_01_afe_config_init(struct phy_device *phydev) >> +{ >> +int ret; >> + >> +/* set shadow mode 2 */ >> +ret = phy_set_clr_bits(phydev, MII_BCM7XXX_TES

Re: [PATCH net-next 02/12] net: phy: bcm7xxx: add support for 28nm EPHY

2017-03-13 Thread Andrew Lunn
On Mon, Mar 13, 2017 at 05:41:32PM -0700, Doug Berger wrote: > +static int bcm7xxx_28nm_ephy_01_afe_config_init(struct phy_device *phydev) > +{ > + int ret; > + > + /* set shadow mode 2 */ > + ret = phy_set_clr_bits(phydev, MII_BCM7XXX_TEST, > +MII_BCM7XXX_SH

Re: [PATCH net-next 02/12] net: phy: bcm7xxx: add support for 28nm EPHY

2017-03-13 Thread Florian Fainelli
On 03/13/2017 05:41 PM, Doug Berger wrote: > This commit adds support for the internal fast ethernet 10/100 PHY > found in the BCM7260, BCM7268, and BCM7271 devices. > > Signed-off-by: Doug Berger Reviewed-by: Florian Fainelli -- Florian

[PATCH net-next 02/12] net: phy: bcm7xxx: add support for 28nm EPHY

2017-03-13 Thread Doug Berger
This commit adds support for the internal fast ethernet 10/100 PHY found in the BCM7260, BCM7268, and BCM7271 devices. Signed-off-by: Doug Berger --- drivers/net/phy/bcm7xxx.c | 215 +- include/linux/brcmphy.h | 3 + 2 files changed, 216 insertions