Re: [PATCH net-next] xdp: xdp_umem: fix umem pages mapping for 32bits systems

2019-07-01 Thread Björn Töpel
On Sat, 29 Jun 2019 at 19:53, David Miller wrote: > > From: Björn Töpel > Date: Wed, 26 Jun 2019 22:50:23 +0200 > > > On Wed, 26 Jun 2019 at 17:59, Ivan Khoronzhuk > > wrote: > >> > >> Use kmap instead of page_address as it's not always in low memory. > >> > > > > Ah, some 32-bit love. :-) Thank

Re: [PATCH net-next] xdp: xdp_umem: fix umem pages mapping for 32bits systems

2019-06-29 Thread David Miller
From: Björn Töpel Date: Wed, 26 Jun 2019 22:50:23 +0200 > On Wed, 26 Jun 2019 at 17:59, Ivan Khoronzhuk > wrote: >> >> Use kmap instead of page_address as it's not always in low memory. >> > > Ah, some 32-bit love. :-) Thanks for working on this! > > For future patches, please base AF_XDP patc

Re: [PATCH net-next] xdp: xdp_umem: fix umem pages mapping for 32bits systems

2019-06-27 Thread kbuild test robot
Hi Ivan, Thank you for the patch! Yet something to improve: [auto build test ERROR on net-next/master] url: https://github.com/0day-ci/linux/commits/Ivan-Khoronzhuk/xdp-xdp_umem-fix-umem-pages-mapping-for-32bits-systems/20190627-135949 config: x86_64-randconfig-x004-201925 (attached as .conf

Re: [PATCH net-next] xdp: xdp_umem: fix umem pages mapping for 32bits systems

2019-06-27 Thread kbuild test robot
Hi Ivan, Thank you for the patch! Yet something to improve: [auto build test ERROR on net-next/master] url: https://github.com/0day-ci/linux/commits/Ivan-Khoronzhuk/xdp-xdp_umem-fix-umem-pages-mapping-for-32bits-systems/20190627-135949 config: i386-randconfig-x073-201925 (attached as .config

Re: [PATCH net-next] xdp: xdp_umem: fix umem pages mapping for 32bits systems

2019-06-26 Thread Björn Töpel
On Wed, 26 Jun 2019 at 17:59, Ivan Khoronzhuk wrote: > > Use kmap instead of page_address as it's not always in low memory. > Ah, some 32-bit love. :-) Thanks for working on this! For future patches, please base AF_XDP patches on the bpf/bpf-next tree instead of net/net-next. Acked-by: Björn Tö

[PATCH net-next] xdp: xdp_umem: fix umem pages mapping for 32bits systems

2019-06-26 Thread Ivan Khoronzhuk
Use kmap instead of page_address as it's not always in low memory. Signed-off-by: Ivan Khoronzhuk --- net/xdp/xdp_umem.c | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/net/xdp/xdp_umem.c b/net/xdp/xdp_umem.c index 9c6de4f114f8..d3c1411420fd 100644 --- a/net/xdp/x