Re: [PATCH net-next] udp: Neaten and reduce size of compute_score functions

2014-12-01 Thread Eric Dumazet
On Mon, 2014-12-01 at 19:09 -0800, Joe Perches wrote: > On Mon, 2014-12-01 at 18:59 -0800, Eric Dumazet wrote: > > On Mon, 2014-12-01 at 17:39 -0800, Joe Perches wrote: > > > The compute_score functions are a bit difficult to read. > > > > > > Neaten them a bit to reduce object sizes and make them

Re: [PATCH net-next] udp: Neaten and reduce size of compute_score functions

2014-12-01 Thread Joe Perches
On Mon, 2014-12-01 at 18:59 -0800, Eric Dumazet wrote: > On Mon, 2014-12-01 at 17:39 -0800, Joe Perches wrote: > > The compute_score functions are a bit difficult to read. > > > > Neaten them a bit to reduce object sizes and make them a > > bit more intelligible. > > > > Return early to avoid ind

Re: [PATCH net-next] udp: Neaten and reduce size of compute_score functions

2014-12-01 Thread Eric Dumazet
On Mon, 2014-12-01 at 17:39 -0800, Joe Perches wrote: > The compute_score functions are a bit difficult to read. > > Neaten them a bit to reduce object sizes and make them a > bit more intelligible. > > Return early to avoid indentation and avoid unnecessary > initializations. > Signed-off-by: J

[PATCH net-next] udp: Neaten and reduce size of compute_score functions

2014-12-01 Thread Joe Perches
The compute_score functions are a bit difficult to read. Neaten them a bit to reduce object sizes and make them a bit more intelligible. Return early to avoid indentation and avoid unnecessary initializations. (allyesconfig, but w/ -O2 and no profiling) $ size net/ipv[46]/udp.o.* textdat