Re: [PATCH net-next] bonding: Use do_div to divide 64 bit numbers

2014-01-24 Thread Zoltan Kiss
On 23/01/14 21:18, Nikolay Aleksandrov wrote: Hi Zoltan, Thanks for fixing this, a few comments though: bond->params.miimon can be 0 here that's why there's a check afterwards, also please separate the local variable definitions from the body with a new line. The same applies for downdelay. Nik

Re: [PATCH net-next] bonding: Use do_div to divide 64 bit numbers

2014-01-23 Thread Sergei Shtylyov
Hello. On 23-01-2014 22:47, Zoltan Kiss wrote: Nikolay Aleksandrov's recent bonding option API changes (25a9b54a and e4994612) You should also specify those commits' summary lines. introduced u64 as the type of downdelay and updelay. On 32 bit the division and modulo operations cause com

Re: [PATCH net-next] bonding: Use do_div to divide 64 bit numbers

2014-01-23 Thread Nikolay Aleksandrov
On 01/23/2014 09:44 PM, Nikolay Aleksandrov wrote: > On 01/23/2014 07:47 PM, Zoltan Kiss wrote: >> Nikolay Aleksandrov's recent bonding option API changes (25a9b54a and >> e4994612) >> introduced u64 as the type of downdelay and updelay. On 32 bit the division >> and >> modulo operations cause co

Re: [PATCH net-next] bonding: Use do_div to divide 64 bit numbers

2014-01-23 Thread Nikolay Aleksandrov
On 01/23/2014 07:47 PM, Zoltan Kiss wrote: > Nikolay Aleksandrov's recent bonding option API changes (25a9b54a and > e4994612) > introduced u64 as the type of downdelay and updelay. On 32 bit the division > and > modulo operations cause compile errors: > > ERROR: "__udivdi3" [drivers/net/bonding

[PATCH net-next] bonding: Use do_div to divide 64 bit numbers

2014-01-23 Thread Zoltan Kiss
Nikolay Aleksandrov's recent bonding option API changes (25a9b54a and e4994612) introduced u64 as the type of downdelay and updelay. On 32 bit the division and modulo operations cause compile errors: ERROR: "__udivdi3" [drivers/net/bonding/bonding.ko] undefined! ERROR: "__umoddi3" [drivers/net/bon