Re: [PATCH net] virtio-net: fix the race between channels setting and refill

2013-07-04 Thread Michael S. Tsirkin
On Wed, Jul 03, 2013 at 08:15:52PM +0800, Jason Wang wrote: > Commit 55257d72bd1c51f25106350f4983ec19f62ed1fa (virtio-net: fill only rx > queues > which are being used) tries to refill on demand when changing the number of > channels by call try_refill_recv() directly, this may race: > > - the re

Re: [PATCH net] virtio-net: fix the race between channels setting and refill

2013-07-03 Thread Rusty Russell
Jason Wang writes: > Commit 55257d72bd1c51f25106350f4983ec19f62ed1fa (virtio-net: fill only rx > queues > which are being used) tries to refill on demand when changing the number of > channels by call try_refill_recv() directly, this may race: > > - the refill work who may do the refill in the sa

Re: [PATCH net] virtio-net: fix the race between channels setting and refill

2013-07-03 Thread Asias He
On Wed, Jul 03, 2013 at 08:15:52PM +0800, Jason Wang wrote: > Commit 55257d72bd1c51f25106350f4983ec19f62ed1fa (virtio-net: fill only rx > queues > which are being used) tries to refill on demand when changing the number of > channels by call try_refill_recv() directly, this may race: > > - the re

Re: [PATCH net] virtio-net: fix the race between channels setting and refill

2013-07-03 Thread David Miller
From: Jason Wang Date: Wed, 3 Jul 2013 20:15:52 +0800 > Commit 55257d72bd1c51f25106350f4983ec19f62ed1fa (virtio-net: fill only rx > queues > which are being used) tries to refill on demand when changing the number of > channels by call try_refill_recv() directly, this may race: > > - the refil

[PATCH net] virtio-net: fix the race between channels setting and refill

2013-07-03 Thread Jason Wang
Commit 55257d72bd1c51f25106350f4983ec19f62ed1fa (virtio-net: fill only rx queues which are being used) tries to refill on demand when changing the number of channels by call try_refill_recv() directly, this may race: - the refill work who may do the refill in the same time - the try_refill_recv()