Re: [PATCH net] virtio-net: don't free skb immediately on kick failure

2014-03-23 Thread Michael S. Tsirkin
On Mon, Mar 24, 2014 at 01:31:57PM +0800, Jason Wang wrote: > On 03/23/2014 07:27 PM, Michael S. Tsirkin wrote: > > On Fri, Mar 21, 2014 at 04:30:01PM +0800, Jason Wang wrote: > >> We free the skb immediately on kick failure during xmit without detaching > >> it > >> from the virtqueue. This may l

Re: [PATCH net] virtio-net: don't free skb immediately on kick failure

2014-03-23 Thread Jason Wang
On 03/23/2014 07:27 PM, Michael S. Tsirkin wrote: > On Fri, Mar 21, 2014 at 04:30:01PM +0800, Jason Wang wrote: >> We free the skb immediately on kick failure during xmit without detaching it >> from the virtqueue. This may lead double free for the skb during >> free_unused_bufs(). This patch fixes

Re: [PATCH net] virtio-net: don't free skb immediately on kick failure

2014-03-23 Thread Michael S. Tsirkin
On Fri, Mar 21, 2014 at 04:30:01PM +0800, Jason Wang wrote: > We free the skb immediately on kick failure during xmit without detaching it > from the virtqueue. This may lead double free for the skb during > free_unused_bufs(). This patch fixes this by not freeing it on kick failure > and > let it

[PATCH net] virtio-net: don't free skb immediately on kick failure

2014-03-21 Thread Jason Wang
We free the skb immediately on kick failure during xmit without detaching it from the virtqueue. This may lead double free for the skb during free_unused_bufs(). This patch fixes this by not freeing it on kick failure and let it to be freed through free_unused_bufs(). Fixes 67975901183799af8e93ec6