Re: [PATCH net] virtio-net: correct error handling of virtqueue_kick()

2014-03-27 Thread David Miller
From: Jason Wang Date: Wed, 26 Mar 2014 13:03:00 +0800 > Current error handling of virtqueue_kick() was wrong in two places: > - The skb were freed immediately when virtqueue_kick() fail during > xmit. This may lead double free since the skb was not detached from > the virtqueue. > - try_fill

Re: [PATCH net] virtio-net: correct error handling of virtqueue_kick()

2014-03-26 Thread Michael S. Tsirkin
On Wed, Mar 26, 2014 at 01:03:00PM +0800, Jason Wang wrote: > Current error handling of virtqueue_kick() was wrong in two places: > - The skb were freed immediately when virtqueue_kick() fail during > xmit. This may lead double free since the skb was not detached from > the virtqueue. > - try_f

[PATCH net] virtio-net: correct error handling of virtqueue_kick()

2014-03-25 Thread Jason Wang
Current error handling of virtqueue_kick() was wrong in two places: - The skb were freed immediately when virtqueue_kick() fail during xmit. This may lead double free since the skb was not detached from the virtqueue. - try_fill_recv() returns false when virtqueue_kick() fail. This will lead