Re: [PATCH net] net: l2tp: reduce log level when passing up invalid packets

2021-03-01 Thread Matthias Schiffer
On 2/23/21 10:47 AM, Tom Parkin wrote: On Mon, Feb 22, 2021 at 14:31:38 -0800, Jakub Kicinski wrote: On Mon, 22 Feb 2021 17:40:16 +0100 Matthias Schiffer wrote: This will not be sufficient for my usecase: To stay compatible with older versions of fastd, I can't set the T flag in the first pack

Re: [PATCH net] net: l2tp: reduce log level when passing up invalid packets

2021-02-23 Thread Tom Parkin
On Mon, Feb 22, 2021 at 14:31:38 -0800, Jakub Kicinski wrote: > On Mon, 22 Feb 2021 17:40:16 +0100 Matthias Schiffer wrote: > > >> This will not be sufficient for my usecase: To stay compatible with older > > >> versions of fastd, I can't set the T flag in the first packet of the > > >> handshake,

Re: [PATCH net] net: l2tp: reduce log level when passing up invalid packets

2021-02-23 Thread Tom Parkin
On Mon, Feb 22, 2021 at 17:40:16 +0100, Matthias Schiffer wrote: > On 2/22/21 12:49 PM, Tom Parkin wrote: > > On Sat, Feb 20, 2021 at 10:56:33 +0100, Matthias Schiffer wrote: > > > On 2/19/21 9:12 PM, Tom Parkin wrote: > > > > On Fri, Feb 19, 2021 at 20:06:15 +0100, Matthias Schiffer wrote: > >

Re: [PATCH net] net: l2tp: reduce log level when passing up invalid packets

2021-02-22 Thread Jakub Kicinski
On Mon, 22 Feb 2021 17:40:16 +0100 Matthias Schiffer wrote: > >> This will not be sufficient for my usecase: To stay compatible with older > >> versions of fastd, I can't set the T flag in the first packet of the > >> handshake, as it won't be known whether the peer has a new enough fastd > >> vers

Re: [PATCH net] net: l2tp: reduce log level when passing up invalid packets

2021-02-22 Thread Matthias Schiffer
On 2/22/21 12:49 PM, Tom Parkin wrote: On Sat, Feb 20, 2021 at 10:56:33 +0100, Matthias Schiffer wrote: On 2/19/21 9:12 PM, Tom Parkin wrote: On Fri, Feb 19, 2021 at 20:06:15 +0100, Matthias Schiffer wrote: Before commit 5ee759cda51b ("l2tp: use standard API for warning log messages"), it wa

Re: [PATCH net] net: l2tp: reduce log level when passing up invalid packets

2021-02-22 Thread Tom Parkin
On Sat, Feb 20, 2021 at 10:56:33 +0100, Matthias Schiffer wrote: > On 2/19/21 9:12 PM, Tom Parkin wrote: > > On Fri, Feb 19, 2021 at 20:06:15 +0100, Matthias Schiffer wrote: > > > Before commit 5ee759cda51b ("l2tp: use standard API for warning log > > > messages"), it was possible for userspace a

Re: [PATCH net] net: l2tp: reduce log level when passing up invalid packets

2021-02-20 Thread Matthias Schiffer
Hi Tom, On 2/19/21 9:12 PM, Tom Parkin wrote: Hi Matthias, Thanks for your patch! On Fri, Feb 19, 2021 at 20:06:15 +0100, Matthias Schiffer wrote: Before commit 5ee759cda51b ("l2tp: use standard API for warning log messages"), it was possible for userspace applications to use their own contr

Re: [PATCH net] net: l2tp: reduce log level when passing up invalid packets

2021-02-19 Thread Tom Parkin
Hi Matthias, Thanks for your patch! On Fri, Feb 19, 2021 at 20:06:15 +0100, Matthias Schiffer wrote: > Before commit 5ee759cda51b ("l2tp: use standard API for warning log > messages"), it was possible for userspace applications to use their own > control protocols on the backing sockets of an L2

[PATCH net] net: l2tp: reduce log level when passing up invalid packets

2021-02-19 Thread Matthias Schiffer
Before commit 5ee759cda51b ("l2tp: use standard API for warning log messages"), it was possible for userspace applications to use their own control protocols on the backing sockets of an L2TP kernel device, and as long as a packet didn't look like a proper L2TP data packet, it would be passed up to