Re: [PATCH net] net: hns: fix LED configuration for marvell phy

2019-07-28 Thread Andrew Lunn
On Sun, Jul 28, 2019 at 03:24:12PM +0200, Pavel Machek wrote: > On Thu 2019-07-25 06:28:29, Andrew Lunn wrote: > > On Thu, Jul 25, 2019 at 11:00:08AM +0800, liuyonglong wrote: > > > > Revert "net: hns: fix LED configuration for marvell phy" > > > > This reverts commit f4e5f775db5a4631300dccd0de5eaf

Re: [PATCH net] net: hns: fix LED configuration for marvell phy

2019-07-28 Thread Pavel Machek
On Thu 2019-07-25 06:28:29, Andrew Lunn wrote: > On Thu, Jul 25, 2019 at 11:00:08AM +0800, liuyonglong wrote: > > > Revert "net: hns: fix LED configuration for marvell phy" > > > This reverts commit f4e5f775db5a4631300dccd0de5eafb50a77c131. > > > > > > Andrew Lunn says this should be handled anothe

Re: [PATCH net] net: hns: fix LED configuration for marvell phy

2019-07-25 Thread liuyonglong
On 2019/7/25 21:08, Andrew Lunn wrote: >> You are discussing about the DT configuration, is Matthias Kaehlcke's work >> also provide a generic way to configure PHY LEDS using ACPI? > > In general, you should be able to use the same properties in ACPI as > DT. If the device_property_read_X() API

Re: [PATCH net] net: hns: fix LED configuration for marvell phy

2019-07-25 Thread Andrew Lunn
> You are discussing about the DT configuration, is Matthias Kaehlcke's work > also provide a generic way to configure PHY LEDS using ACPI? In general, you should be able to use the same properties in ACPI as DT. If the device_property_read_X() API is used, it will try both ACPI and OF to get the

Re: [PATCH net] net: hns: fix LED configuration for marvell phy

2019-07-24 Thread liuyonglong
On 2019/7/25 12:28, Andrew Lunn wrote: > On Thu, Jul 25, 2019 at 11:00:08AM +0800, liuyonglong wrote: >>> Revert "net: hns: fix LED configuration for marvell phy" >>> This reverts commit f4e5f775db5a4631300dccd0de5eafb50a77c131. >>> >>> Andrew Lunn says this should be handled another way. >>> >>

Re: [PATCH net] net: hns: fix LED configuration for marvell phy

2019-07-24 Thread Andrew Lunn
On Thu, Jul 25, 2019 at 11:00:08AM +0800, liuyonglong wrote: > > Revert "net: hns: fix LED configuration for marvell phy" > > This reverts commit f4e5f775db5a4631300dccd0de5eafb50a77c131. > > > > Andrew Lunn says this should be handled another way. > > > > Signed-off-by: David S. Miller > > > Hi

Re: [PATCH net] net: hns: fix LED configuration for marvell phy

2019-07-24 Thread liuyonglong
> Revert "net: hns: fix LED configuration for marvell phy" > This reverts commit f4e5f775db5a4631300dccd0de5eafb50a77c131. > > Andrew Lunn says this should be handled another way. > > Signed-off-by: David S. Miller Hi Andrew: I see this patch have been reverted, can you tell me the better way t

Re: [PATCH net] net: hns: fix LED configuration for marvell phy

2019-07-22 Thread David Miller
From: Yonglong Liu Date: Mon, 22 Jul 2019 13:59:12 +0800 > Since commit(net: phy: marvell: change default m88e1510 LED configuration), > the active LED of Hip07 devices is always off, because Hip07 just > use 2 LEDs. > This patch adds a phy_register_fixup_for_uid() for m88e1510 to > correct the L

[PATCH net] net: hns: fix LED configuration for marvell phy

2019-07-21 Thread Yonglong Liu
Since commit(net: phy: marvell: change default m88e1510 LED configuration), the active LED of Hip07 devices is always off, because Hip07 just use 2 LEDs. This patch adds a phy_register_fixup_for_uid() for m88e1510 to correct the LED configuration. Fixes: 02468ec1 ("net: phy: marvell: change de