Re: [PATCH net] net: flow_dissector: fail on evil iph->ihl

2013-11-03 Thread Daniel Borkmann
On 11/01/2013 08:01 AM, Jason Wang wrote: We don't validate iph->ihl which may lead a dead loop if we meet a IPIP skb whose iph->ihl is zero. Fix this by failing immediately when iph->ihl is evil (less than 5). This issue were introduced by commit ec5efe7946280d1e84603389a1030ccec0a767ae (rps: s

Re: [PATCH net] net: flow_dissector: fail on evil iph->ihl

2013-11-02 Thread Michael S. Tsirkin
On Fri, Nov 01, 2013 at 03:01:10PM +0800, Jason Wang wrote: > We don't validate iph->ihl which may lead a dead loop if we meet a IPIP > skb whose iph->ihl is zero. Fix this by failing immediately when iph->ihl > is evil (less than 5). > > This issue were introduced by commit ec5efe7946280d1e846033

Re: [PATCH net] net: flow_dissector: fail on evil iph->ihl

2013-11-01 Thread David Miller
From: Jason Wang Date: Fri, 1 Nov 2013 15:01:10 +0800 > We don't validate iph->ihl which may lead a dead loop if we meet a IPIP > skb whose iph->ihl is zero. Fix this by failing immediately when iph->ihl > is evil (less than 5). > > This issue were introduced by commit ec5efe7946280d1e84603389a

Re: [PATCH net] net: flow_dissector: fail on evil iph->ihl

2013-11-01 Thread Ben Hutchings
On Fri, 2013-11-01 at 15:01 +0800, Jason Wang wrote: > We don't validate iph->ihl which may lead a dead loop if we meet a IPIP > skb whose iph->ihl is zero. Fix this by failing immediately when iph->ihl > is evil (less than 5). > > This issue were introduced by commit ec5efe7946280d1e84603389a1030

Re: [PATCH net] net: flow_dissector: fail on evil iph->ihl

2013-11-01 Thread Eric Dumazet
On Fri, 2013-11-01 at 15:01 +0800, Jason Wang wrote: > We don't validate iph->ihl which may lead a dead loop if we meet a IPIP > skb whose iph->ihl is zero. Fix this by failing immediately when iph->ihl > is evil (less than 5). > > This issue were introduced by commit ec5efe7946280d1e84603389a1030

[PATCH net] net: flow_dissector: fail on evil iph->ihl

2013-11-01 Thread Jason Wang
We don't validate iph->ihl which may lead a dead loop if we meet a IPIP skb whose iph->ihl is zero. Fix this by failing immediately when iph->ihl is evil (less than 5). This issue were introduced by commit ec5efe7946280d1e84603389a1030ccec0a767ae (rps: support IPIP encapsulation). Cc: Eric Dumaze