Re: [PATCH net] mpls: fix af_mpls dependencies

2019-06-14 Thread Randy Dunlap
On 6/14/19 7:26 AM, Arnd Bergmann wrote: > On Fri, Jun 14, 2019 at 4:07 PM David Ahern wrote: >> On 6/14/19 8:01 AM, Arnd Bergmann wrote: >>> On Wed, Jun 12, 2019 at 9:41 AM Randy Dunlap wrote: On 6/11/19 5:08 PM, Matteo Croce wrote: >>> >>> It clearly shouldn't select PROC_SYSCTL, but I thi

Re: [PATCH net] mpls: fix af_mpls dependencies

2019-06-14 Thread Eric W. Biederman
Arnd Bergmann writes: > On Fri, Jun 14, 2019 at 4:07 PM David Ahern wrote: >> On 6/14/19 8:01 AM, Arnd Bergmann wrote: >> > On Wed, Jun 12, 2019 at 9:41 AM Randy Dunlap wrote: >> >> On 6/11/19 5:08 PM, Matteo Croce wrote: >> > >> > It clearly shouldn't select PROC_SYSCTL, but I think it should

Re: [PATCH net] mpls: fix af_mpls dependencies

2019-06-14 Thread Arnd Bergmann
On Fri, Jun 14, 2019 at 4:07 PM David Ahern wrote: > On 6/14/19 8:01 AM, Arnd Bergmann wrote: > > On Wed, Jun 12, 2019 at 9:41 AM Randy Dunlap wrote: > >> On 6/11/19 5:08 PM, Matteo Croce wrote: > > > > It clearly shouldn't select PROC_SYSCTL, but I think it should not > > have a 'depends on' sta

Re: [PATCH net] mpls: fix af_mpls dependencies

2019-06-14 Thread David Ahern
On 6/14/19 8:01 AM, Arnd Bergmann wrote: > On Wed, Jun 12, 2019 at 9:41 AM Randy Dunlap wrote: >> On 6/11/19 5:08 PM, Matteo Croce wrote: >>> On Wed, Jun 12, 2019 at 1:07 AM Randy Dunlap wrote: >>> * Configure standard kernel features (expert users) >>> * >>> Configure standard kernel features (e

Re: [PATCH net] mpls: fix af_mpls dependencies

2019-06-14 Thread Arnd Bergmann
On Wed, Jun 12, 2019 at 9:41 AM Randy Dunlap wrote: > On 6/11/19 5:08 PM, Matteo Croce wrote: > > On Wed, Jun 12, 2019 at 1:07 AM Randy Dunlap wrote: > > * Configure standard kernel features (expert users) > > * > > Configure standard kernel features (expert users) (EXPERT) [Y/?] y > > Multiple

Re: [PATCH net] mpls: fix af_mpls dependencies for real

2019-06-12 Thread David Miller
From: Matteo Croce Date: Wed, 12 Jun 2019 11:50:37 +0200 > Randy reported that selecting MPLS_ROUTING without PROC_FS breaks > the build, because since commit c1a9d65954c6 ("mpls: fix af_mpls > dependencies"), MPLS_ROUTING selects PROC_SYSCTL, but Kconfig's select > doesn't recursively handle dep

[PATCH net] mpls: fix af_mpls dependencies for real

2019-06-12 Thread Matteo Croce
Randy reported that selecting MPLS_ROUTING without PROC_FS breaks the build, because since commit c1a9d65954c6 ("mpls: fix af_mpls dependencies"), MPLS_ROUTING selects PROC_SYSCTL, but Kconfig's select doesn't recursively handle dependencies. Change the select into a dependency. Fixes: c1a9d65954c

Re: [PATCH net] mpls: fix af_mpls dependencies

2019-06-11 Thread Randy Dunlap
On 6/11/19 5:08 PM, Matteo Croce wrote: > On Wed, Jun 12, 2019 at 1:07 AM Randy Dunlap wrote: >> >> On 6/9/19 7:57 PM, David Miller wrote: >>> From: Matteo Croce >>> Date: Sat, 8 Jun 2019 14:50:19 +0200 >>> MPLS routing code relies on sysctl to work, so let it select PROC_SYSCTL.

Re: [PATCH net] mpls: fix af_mpls dependencies

2019-06-11 Thread Matteo Croce
On Wed, Jun 12, 2019 at 1:07 AM Randy Dunlap wrote: > > On 6/9/19 7:57 PM, David Miller wrote: > > From: Matteo Croce > > Date: Sat, 8 Jun 2019 14:50:19 +0200 > > > >> MPLS routing code relies on sysctl to work, so let it select PROC_SYSCTL. > >> > >> Reported-by: Randy Dunlap > >> Suggested-by

Re: [PATCH net] mpls: fix af_mpls dependencies

2019-06-11 Thread Randy Dunlap
On 6/9/19 7:57 PM, David Miller wrote: > From: Matteo Croce > Date: Sat, 8 Jun 2019 14:50:19 +0200 > >> MPLS routing code relies on sysctl to work, so let it select PROC_SYSCTL. >> >> Reported-by: Randy Dunlap >> Suggested-by: David Ahern >> Signed-off-by: Matteo Croce > > Applied, thanks. >

Re: [PATCH net] mpls: fix af_mpls dependencies

2019-06-09 Thread David Miller
From: Matteo Croce Date: Sat, 8 Jun 2019 14:50:19 +0200 > MPLS routing code relies on sysctl to work, so let it select PROC_SYSCTL. > > Reported-by: Randy Dunlap > Suggested-by: David Ahern > Signed-off-by: Matteo Croce Applied, thanks.

[PATCH net] mpls: fix af_mpls dependencies

2019-06-08 Thread Matteo Croce
MPLS routing code relies on sysctl to work, so let it select PROC_SYSCTL. Reported-by: Randy Dunlap Suggested-by: David Ahern Signed-off-by: Matteo Croce --- net/mpls/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/net/mpls/Kconfig b/net/mpls/Kconfig index d9391beea980..2b802a48d5a