Re: [PATCH net] ethtool: add and use message type for tunnel info reply

2020-09-17 Thread David Miller
From: Michal Kubecek Date: Thu, 17 Sep 2020 01:04:10 +0200 (CEST) > Tunnel offload info code uses ETHTOOL_MSG_TUNNEL_INFO_GET message type (cmd > field in genetlink header) for replies to tunnel info netlink request, i.e. > the same value as the request have. This is a problem because we are usin

Re: [PATCH net] ethtool: add and use message type for tunnel info reply

2020-09-17 Thread Andrew Lunn
> On the other hand, the enums are part of userspace API so I better take > a closer look to make sure we don't run into some trouble there. Hi Michal Yes, that is what i was thinking about. But i guess you can pass a tagged enum to a function expecting an int and the compiler will silently cast

Re: [PATCH net] ethtool: add and use message type for tunnel info reply

2020-09-17 Thread Michal Kubecek
On Thu, Sep 17, 2020 at 03:41:51AM +0200, Andrew Lunn wrote: > On Thu, Sep 17, 2020 at 01:04:10AM +0200, Michal Kubecek wrote: > > Tunnel offload info code uses ETHTOOL_MSG_TUNNEL_INFO_GET message type (cmd > > field in genetlink header) for replies to tunnel info netlink request, i.e. > > the same

Re: [PATCH net] ethtool: add and use message type for tunnel info reply

2020-09-16 Thread Andrew Lunn
On Thu, Sep 17, 2020 at 01:04:10AM +0200, Michal Kubecek wrote: > Tunnel offload info code uses ETHTOOL_MSG_TUNNEL_INFO_GET message type (cmd > field in genetlink header) for replies to tunnel info netlink request, i.e. > the same value as the request have. This is a problem because we are using >

Re: [PATCH net] ethtool: add and use message type for tunnel info reply

2020-09-16 Thread Jakub Kicinski
On Thu, 17 Sep 2020 01:04:10 +0200 (CEST) Michal Kubecek wrote: > Tunnel offload info code uses ETHTOOL_MSG_TUNNEL_INFO_GET message type (cmd > field in genetlink header) for replies to tunnel info netlink request, i.e. > the same value as the request have. This is a problem because we are using >

[PATCH net] ethtool: add and use message type for tunnel info reply

2020-09-16 Thread Michal Kubecek
Tunnel offload info code uses ETHTOOL_MSG_TUNNEL_INFO_GET message type (cmd field in genetlink header) for replies to tunnel info netlink request, i.e. the same value as the request have. This is a problem because we are using two separate enums for userspace to kernel and kernel to userspace messa