Re: [PATCH net] bonding: show saner speed for broadcast mode

2020-08-13 Thread Michal Kubecek
On Wed, Aug 12, 2020 at 10:29:56PM -0700, Jay Vosburgh wrote: > Did you notice this by inspection, or did it come up in use > somewhere? I can't recall ever hearing of anyone using broadcast mode, > so I'm curious if there is a use for it, but this change seems > reasonable enough regardless

Re: [PATCH net] bonding: show saner speed for broadcast mode

2020-08-13 Thread Jarod Wilson
On Thu, Aug 13, 2020 at 1:30 AM Jay Vosburgh wrote: > > Jarod Wilson wrote: > > >Broadcast mode bonds transmit a copy of all traffic simultaneously out of > >all interfaces, so the "speed" of the bond isn't really the aggregate of > >all interfaces, but rather, the speed of the lowest active inte

Re: [PATCH net] bonding: show saner speed for broadcast mode

2020-08-12 Thread Jay Vosburgh
Jarod Wilson wrote: >Broadcast mode bonds transmit a copy of all traffic simultaneously out of >all interfaces, so the "speed" of the bond isn't really the aggregate of >all interfaces, but rather, the speed of the lowest active interface. Did you mean "slowest" here? >Also, the type of

[PATCH net] bonding: show saner speed for broadcast mode

2020-08-12 Thread Jarod Wilson
Broadcast mode bonds transmit a copy of all traffic simultaneously out of all interfaces, so the "speed" of the bond isn't really the aggregate of all interfaces, but rather, the speed of the lowest active interface. Also, the type of the speed field is u32, not unsigned long, so adjust that accor