Re: [PATCH net] RDS: IB: Limit the scope of has_fr/has_fmr variables

2017-10-03 Thread David Miller
From: Santosh Shilimkar Date: Tue, 3 Oct 2017 17:42:39 -0700 > Hi Dave, > > On 10/2/2017 1:30 PM, Santosh Shilimkar wrote: >> On 10/1/2017 10:56 PM, David Miller wrote: >>> From: David Miller > [...] > >>> >>> Actually, reverted, this breaks the build. >>> >>> net/rds/rdma_transport.c:38:10: f

Re: [PATCH net] RDS: IB: Limit the scope of has_fr/has_fmr variables

2017-10-03 Thread Santosh Shilimkar
Hi Dave, On 10/2/2017 1:30 PM, Santosh Shilimkar wrote: On 10/1/2017 10:56 PM, David Miller wrote: From: David Miller [...] Actually, reverted, this breaks the build. net/rds/rdma_transport.c:38:10: fatal error: ib.h: No such file or directory   #include "ib.h" Although I can't see how

Re: [PATCH net] RDS: IB: Limit the scope of has_fr/has_fmr variables

2017-10-02 Thread Santosh Shilimkar
On 10/1/2017 10:56 PM, David Miller wrote: From: David Miller Date: Sun, 01 Oct 2017 22:54:19 -0700 (PDT) From: Avinash Repaka Date: Fri, 29 Sep 2017 18:13:50 -0700 This patch fixes the scope of has_fr and has_fmr variables as they are needed only in rds_ib_add_one(). Signed-off-by: Avinas

Re: [PATCH net] RDS: IB: Limit the scope of has_fr/has_fmr variables

2017-10-01 Thread David Miller
From: David Miller Date: Sun, 01 Oct 2017 22:54:19 -0700 (PDT) > From: Avinash Repaka > Date: Fri, 29 Sep 2017 18:13:50 -0700 > >> This patch fixes the scope of has_fr and has_fmr variables as they are >> needed only in rds_ib_add_one(). >> >> Signed-off-by: Avinash Repaka > > Applied. Actu

Re: [PATCH net] RDS: IB: Limit the scope of has_fr/has_fmr variables

2017-10-01 Thread David Miller
From: Avinash Repaka Date: Fri, 29 Sep 2017 18:13:50 -0700 > This patch fixes the scope of has_fr and has_fmr variables as they are > needed only in rds_ib_add_one(). > > Signed-off-by: Avinash Repaka Applied.

Re: [PATCH net] RDS: IB: Limit the scope of has_fr/has_fmr variables

2017-09-29 Thread Santosh Shilimkar
On 9/29/2017 6:13 PM, Avinash Repaka wrote: This patch fixes the scope of has_fr and has_fmr variables as they are needed only in rds_ib_add_one(). Signed-off-by: Avinash Repaka --- Indeed the final merge version actually didn't need those across files. Change looks good to me. Thanks !! Acke

[PATCH net] RDS: IB: Limit the scope of has_fr/has_fmr variables

2017-09-29 Thread Avinash Repaka
This patch fixes the scope of has_fr and has_fmr variables as they are needed only in rds_ib_add_one(). Signed-off-by: Avinash Repaka --- net/rds/ib.c | 11 ++- net/rds/ib.h | 2 -- 2 files changed, 6 insertions(+), 7 deletions(-) diff --git a/net/rds/ib.c b/net/rds/ib.c index a0954ac.