Re: [PATCH linux] drivers/fsi: Add SBEFIFO FSI client device driver

2017-06-20 Thread Eddie James
On 06/15/2017 5:24 AM, gre...@linuxfoundation.org wrote: On Wed, Jun 14, 2017 at 02:47:27PM -0500, Edward A. James wrote: +struct sbefifo { +struct timer_list poll_timer; +struct fsi_device *fsi_dev; +struct miscdev

Re: [PATCH linux] drivers/fsi: Add SBEFIFO FSI client device driver

2017-06-14 Thread Greg KH
On Wed, Jun 14, 2017 at 02:47:27PM -0500, Edward A. James wrote: > +struct sbefifo { > + struct timer_list poll_timer; > + struct fsi_device *fsi_dev; > + struct miscdevice mdev; > + wait_queue_head_t wait; > + struct list_head link; > + struct list_head xfrs; > + struct

Re: [PATCH linux] drivers/fsi: Add SBEFIFO FSI client device driver

2017-06-14 Thread Greg KH
On Wed, Jun 14, 2017 at 02:47:27PM -0500, Edward A. James wrote: > +static ssize_t sbefifo_read(struct file *file, char __user *buf, > + size_t len, loff_t *offset) > +{ > + struct sbefifo_client *client = file->private_data; > + > + WARN_ON(*offset); Huh? Why? > + if (!a

Re: [PATCH linux] drivers/fsi: Add SBEFIFO FSI client device driver

2017-06-14 Thread Greg KH
On Wed, Jun 14, 2017 at 02:47:27PM -0500, Edward A. James wrote: > + dev_info(dev, "Found sbefifo device\n"); Don't be chatty, this isn't needed at all, right? thanks, greg k-h

Re: [PATCH linux] drivers/fsi: Add SBEFIFO FSI client device driver

2017-06-14 Thread Greg KH
On Wed, Jun 14, 2017 at 02:47:27PM -0500, Edward A. James wrote: > --- /dev/null > +++ b/include/linux/fsi-sbefifo.h > @@ -0,0 +1,30 @@ > +/* > + * SBEFIFO FSI Client device driver > + * > + * Copyright (C) IBM Corporation 2017 > + * > + * This program is free software; you can redistribute it and/

Re: [PATCH linux] drivers/fsi: Add SBEFIFO FSI client device driver

2017-06-14 Thread Greg KH
On Wed, Jun 14, 2017 at 02:47:27PM -0500, Edward A. James wrote: > +static DEFINE_IDA(sbefifo_ida); WHen your module exits, you don't clean up this structure. Common mistake :) thanks, greg k-h

[PATCH linux] drivers/fsi: Add SBEFIFO FSI client device driver

2017-06-14 Thread Edward A. James
From: "Edward A. James" IBM POWER9 processors contain some embedded hardware and software bits collectively referred to as the self boot engine (SBE). One role of the SBE is to act as a proxy that provides access to the registers of the POWER chip from other (embedded) systems. The POWER9 chip