Re: [PATCH libata #promise-sata-pata] sata_promise: 2037x PATAPI support

2007-01-08 Thread Alan
> IMO creating a new check_atapi_dma function for first-gen chips would be > the preferred way to add this check. A mode filter would be even better, that will mean the list of modes on the device is correct and ATAPI devices are shown as PIO on such a controller. - To unsubscribe from this list:

Re: [PATCH libata #promise-sata-pata] sata_promise: 2037x PATAPI support

2007-01-08 Thread Mikael Pettersson
On Sun, 07 Jan 2007 20:47:35 -0500, Jeff Garzik wrote: > Mikael Pettersson wrote: > > @@ -789,8 +789,14 @@ static void pdc_exec_command_mmio(struct > > static int pdc_check_atapi_dma(struct ata_queued_cmd *qc) > > { > > u8 *scsicmd = qc->scsicmd->cmnd; > > + struct ata_port *ap = qc->ap; >

Re: [PATCH libata #promise-sata-pata] sata_promise: 2037x PATAPI support

2007-01-07 Thread Jeff Garzik
Mikael Pettersson wrote: @@ -789,8 +789,14 @@ static void pdc_exec_command_mmio(struct static int pdc_check_atapi_dma(struct ata_queued_cmd *qc) { u8 *scsicmd = qc->scsicmd->cmnd; + struct ata_port *ap = qc->ap; + struct pdc_host_priv *hp = ap->host->private_data; in

Re: [PATCH libata #promise-sata-pata] sata_promise: 2037x PATAPI support

2007-01-07 Thread Mikael Pettersson
On Sat, 6 Jan 2007 21:32:03 +0100 (MET), Mikael Pettersson wrote: >This patch adds ATAPI support for the PATA port on Promise 2037x chips. >It depends on the common sata_promise ATAPI support patch. > >First-generation chips don't support ATAPI on their SATA ports, so >the patch removes ATA_FLAG_NO

[PATCH libata #promise-sata-pata] sata_promise: 2037x PATAPI support

2007-01-06 Thread Mikael Pettersson
This patch adds ATAPI support for the PATA port on Promise 2037x chips. It depends on the common sata_promise ATAPI support patch. First-generation chips don't support ATAPI on their SATA ports, so the patch removes ATA_FLAG_NO_ATAPI from the 2037x common host flags, and adds it back via the _port