Re: [PATCH kernel] powerpc/debug: Add missing warn flag to WARN_ON's non-builtin path

2017-06-14 Thread Michael Ellerman
Alexey Kardashevskiy writes: > On 14/06/17 21:04, Michael Ellerman wrote: >> Alexey Kardashevskiy writes: >> >>> When trapped on WARN_ON(), report_bug() is expected to return >>> BUG_TRAP_TYPE_WARN so the caller could increment NIP by 4 and continue. >>> The __builtin_constant_p() path of the P

Re: [PATCH kernel] powerpc/debug: Add missing warn flag to WARN_ON's non-builtin path

2017-06-14 Thread Alexey Kardashevskiy
On 14/06/17 21:04, Michael Ellerman wrote: > Alexey Kardashevskiy writes: > >> When trapped on WARN_ON(), report_bug() is expected to return >> BUG_TRAP_TYPE_WARN so the caller could increment NIP by 4 and continue. >> The __builtin_constant_p() path of the PPC's WARN_ON() calls (indirectly) >> _

[PATCH kernel] powerpc/debug: Add missing warn flag to WARN_ON's non-builtin path

2017-06-13 Thread Alexey Kardashevskiy
When trapped on WARN_ON(), report_bug() is expected to return BUG_TRAP_TYPE_WARN so the caller could increment NIP by 4 and continue. The __builtin_constant_p() path of the PPC's WARN_ON() calls (indirectly) __WARN_FLAGS() which has BUGFLAG_WARNING set, however the other branch does not which makes