Re: [PATCH ghak124 v2] audit: log nftables configuration change events

2020-06-02 Thread Richard Guy Briggs
On 2020-06-01 20:12, Paul Moore wrote: > On Mon, Jun 1, 2020 at 6:58 PM Richard Guy Briggs wrote: > > On 2020-06-01 12:10, Paul Moore wrote: > > > On Thu, May 28, 2020 at 9:44 PM Richard Guy Briggs > > > wrote: > > ... > > > > > diff --git a/net/netfilter/nf_tables_api.c > > > > b/net/netfilt

Re: [PATCH ghak124 v2] audit: log nftables configuration change events

2020-06-01 Thread Paul Moore
On Mon, Jun 1, 2020 at 6:58 PM Richard Guy Briggs wrote: > On 2020-06-01 12:10, Paul Moore wrote: > > On Thu, May 28, 2020 at 9:44 PM Richard Guy Briggs wrote: ... > > > diff --git a/net/netfilter/nf_tables_api.c b/net/netfilter/nf_tables_api.c > > > index 4471393da6d8..7a386eca6e04 100644 > >

Re: [PATCH ghak124 v2] audit: log nftables configuration change events

2020-06-01 Thread Richard Guy Briggs
On 2020-06-01 12:10, Paul Moore wrote: > On Thu, May 28, 2020 at 9:44 PM Richard Guy Briggs wrote: > > iptables, ip6tables, arptables and ebtables table registration, > > replacement and unregistration configuration events are logged for the > > native (legacy) iptables setsockopt api, but not for

Re: [PATCH ghak124 v2] audit: log nftables configuration change events

2020-06-01 Thread Paul Moore
On Thu, May 28, 2020 at 9:44 PM Richard Guy Briggs wrote: > iptables, ip6tables, arptables and ebtables table registration, > replacement and unregistration configuration events are logged for the > native (legacy) iptables setsockopt api, but not for the > nftables netlink api which is used by th

Re: [PATCH ghak124 v2] audit: log nftables configuration change events

2020-05-31 Thread kbuild test robot
Hi Richard, Thank you for the patch! Yet something to improve: [auto build test ERROR on pcmoore-audit/next] [also build test ERROR on next-20200529] [cannot apply to nf/master nf-next/master linus/master linux/master v5.7-rc7] [if your patch is applied to the wrong git tree, please drop us a not

[PATCH ghak124 v2] audit: log nftables configuration change events

2020-05-28 Thread Richard Guy Briggs
iptables, ip6tables, arptables and ebtables table registration, replacement and unregistration configuration events are logged for the native (legacy) iptables setsockopt api, but not for the nftables netlink api which is used by the nft-variant of iptables in addition to nftables itself. Add call