Re: [PATCH char-misc-next 4/4] misc: mic: use common error path

2016-01-06 Thread Sudip Mukherjee
On Fri, Dec 11, 2015 at 06:46:25PM -0800, Sudeep Dutt wrote: > On Mon, 2015-11-23 at 17:24 +0530, Sudip Mukherjee wrote: > > Instead of calling release_firmware() on every error and then jumping > > lets have a common release_firmware() in the error path. > > This patch also fixes a memory leak whe

Re: [PATCH char-misc-next 4/4] misc: mic: use common error path

2015-12-11 Thread Sudeep Dutt
On Mon, 2015-11-23 at 17:24 +0530, Sudip Mukherjee wrote: > Instead of calling release_firmware() on every error and then jumping > lets have a common release_firmware() in the error path. > This patch also fixes a memory leak where we missed release_firmware() > if mic_x100_load_command_line() fai

[PATCH char-misc-next 4/4] misc: mic: use common error path

2015-11-23 Thread Sudip Mukherjee
Instead of calling release_firmware() on every error and then jumping lets have a common release_firmware() in the error path. This patch also fixes a memory leak where we missed release_firmware() if mic_x100_load_command_line() fails. Signed-off-by: Sudip Mukherjee --- drivers/misc/mic/host/mi