Re: [PATCH can-next v5 1/2] can: add tx/rx LED trigger support

2012-08-01 Thread Marc Kleine-Budde
On 08/01/2012 02:06 PM, Oliver Hartkopp wrote: > Sorry for this potentially mangled mail from my webmail access ... > > Fabio Baltieri hat am 1. August 2012 um 13:49 > geschrieben: > >> +void devm_can_led_init(struct net_device *netdev) >> +{ >> + struct can_priv *priv = netdev_priv(netdev); >>

Re: [PATCH can-next v5 1/2] can: add tx/rx LED trigger support

2012-08-01 Thread Oliver Hartkopp
Sorry for this potentially mangled mail from my webmail access ... Fabio Baltieri hat am 1. August 2012 um 13:49 geschrieben: > +void devm_can_led_init(struct net_device *netdev) > +{ > + struct can_priv *priv = netdev_priv(netdev); > + void *res; > + > + res = devres_alloc(can_led_release, 0

Re: [PATCH can-next v5 1/2] can: add tx/rx LED trigger support

2012-08-01 Thread Marc Kleine-Budde
On 08/01/2012 01:49 PM, Fabio Baltieri wrote: > This patch implements the functions to add two LED triggers, named > -tx and -rx, to a canbus device driver. > > Triggers are called from specific handlers by each CAN device driver and > can be disabled altogether with a Kconfig option. > > The imp

[PATCH can-next v5 1/2] can: add tx/rx LED trigger support

2012-08-01 Thread Fabio Baltieri
This patch implements the functions to add two LED triggers, named -tx and -rx, to a canbus device driver. Triggers are called from specific handlers by each CAN device driver and can be disabled altogether with a Kconfig option. The implementation keeps the LED on when the interface is UP and bl