Re: [PATCH btrfs/for-next] btrfs: fix fatal extent_buffer readahead vs releasepage race

2020-06-17 Thread kernel test robot
Hi Boris, Thank you for the patch! Yet something to improve: [auto build test ERROR on kdave/for-next] [also build test ERROR on v5.8-rc1 next-20200617] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to use '--base' option t

Re: [PATCH btrfs/for-next] btrfs: fix fatal extent_buffer readahead vs releasepage race

2020-06-17 Thread kernel test robot
Hi Boris, Thank you for the patch! Yet something to improve: [auto build test ERROR on kdave/for-next] [also build test ERROR on v5.8-rc1 next-20200617] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to use '--base' option t

Re: [PATCH btrfs/for-next] btrfs: fix fatal extent_buffer readahead vs releasepage race

2020-06-17 Thread Filipe Manana
On Wed, Jun 17, 2020 at 7:19 PM Josef Bacik wrote: > > On 6/17/20 2:11 PM, Filipe Manana wrote: > > On Wed, Jun 17, 2020 at 6:43 PM Chris Mason wrote: > >> > >> On 17 Jun 2020, at 13:20, Filipe Manana wrote: > >> > >>> On Wed, Jun 17, 2020 at 5:32 PM Boris Burkov wrote: > >>> > --- >

Re: [PATCH btrfs/for-next] btrfs: fix fatal extent_buffer readahead vs releasepage race

2020-06-17 Thread Josef Bacik
On 6/17/20 2:11 PM, Filipe Manana wrote: On Wed, Jun 17, 2020 at 6:43 PM Chris Mason wrote: On 17 Jun 2020, at 13:20, Filipe Manana wrote: On Wed, Jun 17, 2020 at 5:32 PM Boris Burkov wrote: --- fs/btrfs/extent_io.c | 45 1 file changed, 29

Re: [PATCH btrfs/for-next] btrfs: fix fatal extent_buffer readahead vs releasepage race

2020-06-17 Thread Filipe Manana
On Wed, Jun 17, 2020 at 6:43 PM Chris Mason wrote: > > On 17 Jun 2020, at 13:20, Filipe Manana wrote: > > > On Wed, Jun 17, 2020 at 5:32 PM Boris Burkov wrote: > > > >> --- > >> fs/btrfs/extent_io.c | 45 > >> > >> 1 file changed, 29 insertions(+), 16

Re: [PATCH btrfs/for-next] btrfs: fix fatal extent_buffer readahead vs releasepage race

2020-06-17 Thread Chris Mason
On 17 Jun 2020, at 13:20, Filipe Manana wrote: On Wed, Jun 17, 2020 at 5:32 PM Boris Burkov wrote: --- fs/btrfs/extent_io.c | 45 1 file changed, 29 insertions(+), 16 deletions(-) diff --git a/fs/btrfs/extent_io.c b/fs/btrfs/extent_io.c index c

Re: [PATCH btrfs/for-next] btrfs: fix fatal extent_buffer readahead vs releasepage race

2020-06-17 Thread Filipe Manana
On Wed, Jun 17, 2020 at 6:20 PM Filipe Manana wrote: > > On Wed, Jun 17, 2020 at 5:32 PM Boris Burkov wrote: > > > > Under somewhat convoluted conditions, it is possible to attempt to > > release an extent_buffer that is under io, which triggers a BUG_ON in > > btrfs_release_extent_buffer_pages.

Re: [PATCH btrfs/for-next] btrfs: fix fatal extent_buffer readahead vs releasepage race

2020-06-17 Thread Filipe Manana
On Wed, Jun 17, 2020 at 5:32 PM Boris Burkov wrote: > > Under somewhat convoluted conditions, it is possible to attempt to > release an extent_buffer that is under io, which triggers a BUG_ON in > btrfs_release_extent_buffer_pages. > > This relies on a few different factors. First, extent_buffer r

[PATCH btrfs/for-next] btrfs: fix fatal extent_buffer readahead vs releasepage race

2020-06-17 Thread Boris Burkov
Under somewhat convoluted conditions, it is possible to attempt to release an extent_buffer that is under io, which triggers a BUG_ON in btrfs_release_extent_buffer_pages. This relies on a few different factors. First, extent_buffer reads done as readahead for searching use WAIT_NONE, so they free