Re: [PATCH bpf 1/2] flow_dissector: reject invalid attach_flags

2020-06-23 Thread Lorenz Bauer
On Wed, 17 Jun 2020 at 07:49, John Fastabend wrote: > > Alexei Starovoitov wrote: > > On Tue, Jun 16, 2020 at 1:30 AM Lorenz Bauer wrote: > > > > > > On Tue, 16 Jun 2020 at 04:55, Alexei Starovoitov > > > wrote: > > > > > > > > On Mon, Jun 15, 2020 at 7:43 AM Lorenz Bauer > > > > wrote: > > >

Re: [PATCH bpf 1/2] flow_dissector: reject invalid attach_flags

2020-06-16 Thread John Fastabend
Alexei Starovoitov wrote: > On Tue, Jun 16, 2020 at 1:30 AM Lorenz Bauer wrote: > > > > On Tue, 16 Jun 2020 at 04:55, Alexei Starovoitov > > wrote: > > > > > > On Mon, Jun 15, 2020 at 7:43 AM Lorenz Bauer wrote: > > > > > > > > On Fri, 12 Jun 2020 at 23:36, Alexei Starovoitov > > > > wrote: > >

Re: [PATCH bpf 1/2] flow_dissector: reject invalid attach_flags

2020-06-16 Thread Alexei Starovoitov
On Tue, Jun 16, 2020 at 1:30 AM Lorenz Bauer wrote: > > On Tue, 16 Jun 2020 at 04:55, Alexei Starovoitov > wrote: > > > > On Mon, Jun 15, 2020 at 7:43 AM Lorenz Bauer wrote: > > > > > > On Fri, 12 Jun 2020 at 23:36, Alexei Starovoitov > > > wrote: > > > > > > > > On Fri, Jun 12, 2020 at 9:02 AM

Re: [PATCH bpf 1/2] flow_dissector: reject invalid attach_flags

2020-06-16 Thread Lorenz Bauer
On Tue, 16 Jun 2020 at 04:55, Alexei Starovoitov wrote: > > On Mon, Jun 15, 2020 at 7:43 AM Lorenz Bauer wrote: > > > > On Fri, 12 Jun 2020 at 23:36, Alexei Starovoitov > > wrote: > > > > > > On Fri, Jun 12, 2020 at 9:02 AM Lorenz Bauer wrote: > > > > > > > > Using BPF_PROG_ATTACH on a flow dis

Re: [PATCH bpf 1/2] flow_dissector: reject invalid attach_flags

2020-06-15 Thread Alexei Starovoitov
On Mon, Jun 15, 2020 at 7:43 AM Lorenz Bauer wrote: > > On Fri, 12 Jun 2020 at 23:36, Alexei Starovoitov > wrote: > > > > On Fri, Jun 12, 2020 at 9:02 AM Lorenz Bauer wrote: > > > > > > Using BPF_PROG_ATTACH on a flow dissector program supports neither flags > > > nor target_fd but accepts any v

Re: [PATCH bpf 1/2] flow_dissector: reject invalid attach_flags

2020-06-15 Thread Lorenz Bauer
On Fri, 12 Jun 2020 at 23:36, Alexei Starovoitov wrote: > > On Fri, Jun 12, 2020 at 9:02 AM Lorenz Bauer wrote: > > > > Using BPF_PROG_ATTACH on a flow dissector program supports neither flags > > nor target_fd but accepts any value. Return EINVAL if either are non-zero. > > > > Signed-off-by: Lo

Re: [PATCH bpf 1/2] flow_dissector: reject invalid attach_flags

2020-06-12 Thread Alexei Starovoitov
On Fri, Jun 12, 2020 at 9:02 AM Lorenz Bauer wrote: > > Using BPF_PROG_ATTACH on a flow dissector program supports neither flags > nor target_fd but accepts any value. Return EINVAL if either are non-zero. > > Signed-off-by: Lorenz Bauer > Fixes: b27f7bb590ba ("flow_dissector: Move out netns_bpf

[PATCH bpf 1/2] flow_dissector: reject invalid attach_flags

2020-06-12 Thread Lorenz Bauer
Using BPF_PROG_ATTACH on a flow dissector program supports neither flags nor target_fd but accepts any value. Return EINVAL if either are non-zero. Signed-off-by: Lorenz Bauer Fixes: b27f7bb590ba ("flow_dissector: Move out netns_bpf prog callbacks") --- kernel/bpf/net_namespace.c | 3 +++ 1 file