Re: [PATCH bpf-next v1 1/3] bpf, sockmap: avoid using sk_socket after free

2025-02-27 Thread Jiayuan Chen
On Thu, Feb 27, 2025 at 03:04:26PM -0800, Martin KaFai Lau wrote: > On 2/26/25 5:22 AM, Jiayuan Chen wrote: > > Use RCU lock to protect sk_socket, preventing concurrent close and release > > by another thread. > > > > Because TCP/UDP are already within a relatively large critical section: > > '''

Re: [PATCH bpf-next v1 1/3] bpf, sockmap: avoid using sk_socket after free

2025-02-27 Thread Martin KaFai Lau
On 2/26/25 5:22 AM, Jiayuan Chen wrote: Use RCU lock to protect sk_socket, preventing concurrent close and release by another thread. Because TCP/UDP are already within a relatively large critical section: ''' ip_local_deliver_finish rcu_read_lock ip_protocol_deliver_rcu tcp_rcv/udp

Re: [PATCH bpf-next v1 1/3] bpf, sockmap: avoid using sk_socket after free

2025-02-27 Thread John Fastabend
On 2025-02-27 11:45:53, Cong Wang wrote: > On Wed, Feb 26, 2025 at 09:22:40PM +0800, Jiayuan Chen wrote: > > Use RCU lock to protect sk_socket, preventing concurrent close and release > > by another thread. > > > > Because TCP/UDP are already within a relatively large critical section: > > ''' > >

Re: [PATCH bpf-next v1 1/3] bpf, sockmap: avoid using sk_socket after free

2025-02-27 Thread Cong Wang
On Wed, Feb 26, 2025 at 09:22:40PM +0800, Jiayuan Chen wrote: > Use RCU lock to protect sk_socket, preventing concurrent close and release > by another thread. > > Because TCP/UDP are already within a relatively large critical section: > ''' > ip_local_deliver_finish > rcu_read_lock > ip_proto

[PATCH bpf-next v1 1/3] bpf, sockmap: avoid using sk_socket after free

2025-02-26 Thread Jiayuan Chen
Use RCU lock to protect sk_socket, preventing concurrent close and release by another thread. Because TCP/UDP are already within a relatively large critical section: ''' ip_local_deliver_finish rcu_read_lock ip_protocol_deliver_rcu tcp_rcv/udp_rcv rcu_read_unlock ''' Adding rcu_read_{