Re: [PATCH bpf] xdp: check device pointer before clearing

2019-06-12 Thread Daniel Borkmann
On 06/07/2019 07:27 PM, Ilya Maximets wrote: > We should not call 'ndo_bpf()' or 'dev_put()' with NULL argument. > > Fixes: c9b47cc1fabc ("xsk: fix bug when trying to use both copy and zero-copy > on one queue id") > Signed-off-by: Ilya Maximets Applied, thanks!

Re: [PATCH bpf] xdp: check device pointer before clearing

2019-06-10 Thread Jonathan Lemon
On 7 Jun 2019, at 10:27, Ilya Maximets wrote: We should not call 'ndo_bpf()' or 'dev_put()' with NULL argument. Fixes: c9b47cc1fabc ("xsk: fix bug when trying to use both copy and zero-copy on one queue id") Signed-off-by: Ilya Maximets Acked-by: Jonathan Lemon

[PATCH bpf] xdp: check device pointer before clearing

2019-06-07 Thread Ilya Maximets
We should not call 'ndo_bpf()' or 'dev_put()' with NULL argument. Fixes: c9b47cc1fabc ("xsk: fix bug when trying to use both copy and zero-copy on one queue id") Signed-off-by: Ilya Maximets --- I'm not sure if this fixes any real NULL pointer dereference, but code is not consistent anyway and