RE: [PATCH bpf] selftests/bpf: add XDP_UMEM_TX_METADATA_LEN flag to umem_config

2024-12-20 Thread Wei Fang
> On Fri, Dec 20, 2024 at 05:18:06PM +0800, Wei Fang wrote: > > The Tx metadata test has been broken since the commit d5e726d9143c > ("xsk: > > Require XDP_UMEM_TX_METADATA_LEN to actuate tx_metadata_len"). > > Nit: > > Fixes tag already include this information. > > The Tx metadata test has bee

RE: [PATCH bpf] selftests/bpf: add XDP_UMEM_TX_METADATA_LEN flag to umem_config

2024-12-20 Thread Wei Fang
> On 12/20, Wei Fang wrote: > > The Tx metadata test has been broken since the commit d5e726d9143c > ("xsk: > > Require XDP_UMEM_TX_METADATA_LEN to actuate tx_metadata_len"). > Because > > this change requires XDP_UMEM_TX_METADATA_LEN flag to be set, > > otherwise xsk_buff_pool::tx_metadata_len wil

Re: [PATCH bpf] selftests/bpf: add XDP_UMEM_TX_METADATA_LEN flag to umem_config

2024-12-20 Thread Frank Li
On Fri, Dec 20, 2024 at 05:18:06PM +0800, Wei Fang wrote: > The Tx metadata test has been broken since the commit d5e726d9143c ("xsk: > Require XDP_UMEM_TX_METADATA_LEN to actuate tx_metadata_len"). Nit: Fixes tag already include this information. The Tx metadata test has been broken becasue XDP

Re: [PATCH bpf] selftests/bpf: add XDP_UMEM_TX_METADATA_LEN flag to umem_config

2024-12-20 Thread Stanislav Fomichev
On 12/20, Wei Fang wrote: > The Tx metadata test has been broken since the commit d5e726d9143c ("xsk: > Require XDP_UMEM_TX_METADATA_LEN to actuate tx_metadata_len"). Because > this change requires XDP_UMEM_TX_METADATA_LEN flag to be set, otherwise > xsk_buff_pool::tx_metadata_len will be initializ

[PATCH bpf] selftests/bpf: add XDP_UMEM_TX_METADATA_LEN flag to umem_config

2024-12-20 Thread Wei Fang
The Tx metadata test has been broken since the commit d5e726d9143c ("xsk: Require XDP_UMEM_TX_METADATA_LEN to actuate tx_metadata_len"). Because this change requires XDP_UMEM_TX_METADATA_LEN flag to be set, otherwise xsk_buff_pool::tx_metadata_len will be initialized to 0, which means that the driv