Re: [PATCH again] [libata] libata driver for bf548 on chip ATAPI controller.

2007-08-15 Thread Sonic Zhang
On 8/14/07, Alan Cox <[EMAIL PROTECTED]> wrote: > > +/** > > + * Register transfer timing table > > + */ > > Libata has a complete set of transfer mode tables and timing functions - > any reason for not using them ? > After a bit investigation, I find the timing paramters difined in struct ata_tim

Re: [PATCH again] [libata] libata driver for bf548 on chip ATAPI controller.

2007-08-14 Thread Sonic Zhang
forgot to reply to all. On 8/15/07, Sonic Zhang <[EMAIL PROTECTED]> wrote: > On 8/14/07, Alan Cox <[EMAIL PROTECTED]> wrote: > > > +/** > > > + * Register transfer timing table > > > + */ > > > > Libata has a complete set of transfer mode tables and timing functions - > > any reason for not using

Re: [PATCH again] [libata] libata driver for bf548 on chip ATAPI controller.

2007-08-14 Thread Alan Cox
> +/** > + * Register transfer timing table > + */ Libata has a complete set of transfer mode tables and timing functions - any reason for not using them ? > + /* increase tcyc - tdvs (tcyc_tdvs) until we > meed > +* the minimum cycle length > +

[PATCH again] [libata] libata driver for bf548 on chip ATAPI controller.

2007-08-13 Thread Sonic Zhang
This driver is for bf548 on chip ATAPI controller. Both PIO 4 and UDMA5 mode are enabled. Signed-off-by: Sonic Zhang <[EMAIL PROTECTED]> --- drivers/ata/Kconfig | 28 + drivers/ata/Makefile |1 + drivers/ata/pata_bf54x.c | 1585 ++ 3 fil