Re: [PATCH WIP] parport: add device model

2015-04-13 Thread Greg KH
On Mon, Apr 13, 2015 at 03:32:44PM +0530, Sudip Mukherjee wrote: > On Mon, Apr 13, 2015 at 10:43:39AM +0200, Greg KH wrote: > > On Sat, Apr 11, 2015 at 01:41:34PM +0530, Sudip Mukherjee wrote: > > > On Sat, Apr 11, 2015 at 09:27:16AM +0200, Greg KH wrote: > > > > On Sat, Apr 11, 2015 at 10:56:51AM

Re: [PATCH WIP] parport: add device model

2015-04-13 Thread Dan Carpenter
On Sat, Apr 11, 2015 at 10:56:51AM +0530, Sudip Mukherjee wrote: > On Fri, Apr 10, 2015 at 05:49:55PM +0300, Dan Carpenter wrote: > > On Fri, Apr 10, 2015 at 08:00:38PM +0530, Sudip Mukherjee wrote: > > > > + > > > parport_default_sysctl_table.sysctl_header = > > > register_sysctl_tabl

Re: [PATCH WIP] parport: add device model

2015-04-13 Thread Sudip Mukherjee
On Mon, Apr 13, 2015 at 10:43:39AM +0200, Greg KH wrote: > On Sat, Apr 11, 2015 at 01:41:34PM +0530, Sudip Mukherjee wrote: > > On Sat, Apr 11, 2015 at 09:27:16AM +0200, Greg KH wrote: > > > On Sat, Apr 11, 2015 at 10:56:51AM +0530, Sudip Mukherjee wrote: > > > > > > I can understand that driver

Re: [PATCH WIP] parport: add device model

2015-04-13 Thread Greg KH
On Sat, Apr 11, 2015 at 01:41:34PM +0530, Sudip Mukherjee wrote: > On Sat, Apr 11, 2015 at 09:27:16AM +0200, Greg KH wrote: > > On Sat, Apr 11, 2015 at 10:56:51AM +0530, Sudip Mukherjee wrote: > > > > I know that I have done a rubbish review. I'm going to have to review > > > > this properly later

Re: [PATCH WIP] parport: add device model

2015-04-13 Thread Sudip Mukherjee
On Sat, Apr 11, 2015 at 01:41:34PM +0530, Sudip Mukherjee wrote: > On Sat, Apr 11, 2015 at 09:27:16AM +0200, Greg KH wrote: > > On Sat, Apr 11, 2015 at 10:56:51AM +0530, Sudip Mukherjee wrote: > well, as of now one question. I am planning like this : > >sys > _

Re: [PATCH WIP] parport: add device model

2015-04-11 Thread Ondrej Zary
On Saturday 11 April 2015 07:05:11 you wrote: > On Fri, Apr 10, 2015 at 08:24:23PM +0200, Ondrej Zary wrote: > > On Friday 10 April 2015 16:30:38 Sudip Mukherjee wrote: > > > > Many newer parallel port devices support plug&play (IEEE1284 device ID) > > but Linux never supported it properly. The ID

Re: [PATCH WIP] parport: add device model

2015-04-11 Thread Sudip Mukherjee
On Sat, Apr 11, 2015 at 09:27:16AM +0200, Greg KH wrote: > On Sat, Apr 11, 2015 at 10:56:51AM +0530, Sudip Mukherjee wrote: > > > I know that I have done a rubbish review. I'm going to have to review > > > this properly later. > > main thing i wanted to know is if my approach is correct. since not

Re: [PATCH WIP] parport: add device model

2015-04-11 Thread Greg KH
On Sat, Apr 11, 2015 at 10:56:51AM +0530, Sudip Mukherjee wrote: > > I know that I have done a rubbish review. I'm going to have to review > > this properly later. > main thing i wanted to know is if my approach is correct. since nothing > on that so I hope I am on the correct track. Thanks. > I w

Re: [PATCH WIP] parport: add device model

2015-04-10 Thread Sudip Mukherjee
On Fri, Apr 10, 2015 at 05:49:55PM +0300, Dan Carpenter wrote: > On Fri, Apr 10, 2015 at 08:00:38PM +0530, Sudip Mukherjee wrote: > > + > > parport_default_sysctl_table.sysctl_header = > > register_sysctl_table(parport_default_sysctl_table.dev_dir); > > Should we return an error i

Re: [PATCH WIP] parport: add device model

2015-04-10 Thread Sudip Mukherjee
On Fri, Apr 10, 2015 at 08:24:23PM +0200, Ondrej Zary wrote: > On Friday 10 April 2015 16:30:38 Sudip Mukherjee wrote: > > Many newer parallel port devices support plug&play (IEEE1284 device ID) but > Linux never supported it properly. The ID is probed and even the class is > printed in the kern