Re: [PATCH V8 3/3] OPP: Allow "opp-hz" and "opp-microvolt" to contain magic values

2018-01-12 Thread Stephen Boyd
On 01/10, Viresh Kumar wrote: > On 09-01-18, 18:54, Stephen Boyd wrote: > > My read of Kevin's comments lead me to think he's saying that a > > generic 'domain-performance-state' property is worse than putting > > the numbers directly inside of the opp table with a comment above > > it. Now that's

Re: [PATCH V8 3/3] OPP: Allow "opp-hz" and "opp-microvolt" to contain magic values

2018-01-09 Thread Viresh Kumar
On 09-01-18, 18:54, Stephen Boyd wrote: > My read of Kevin's comments lead me to think he's saying that a > generic 'domain-performance-state' property is worse than putting > the numbers directly inside of the opp table with a comment above > it. Now that's all fine, but now that we have required-

Re: [PATCH V8 3/3] OPP: Allow "opp-hz" and "opp-microvolt" to contain magic values

2018-01-09 Thread Stephen Boyd
On 01/08, Viresh Kumar wrote: > On 05-01-18, 14:19, Stephen Boyd wrote: > > On 12/29, Viresh Kumar wrote: > > > Could you please point to Kevin's comments and also include the > > https://lkml.kernel.org/r/m2r30i4w35@baylibre.com Ok. That thread was months ago. Shocked I can't remember! My

Re: [PATCH V8 3/3] OPP: Allow "opp-hz" and "opp-microvolt" to contain magic values

2018-01-07 Thread Viresh Kumar
On 05-01-18, 14:19, Stephen Boyd wrote: > On 12/29, Viresh Kumar wrote: > Could you please point to Kevin's comments and also include the https://lkml.kernel.org/r/m2r30i4w35@baylibre.com > reasoning behind magic values in the commit text for the patch? > It would be very helpful to know why

Re: [PATCH V8 3/3] OPP: Allow "opp-hz" and "opp-microvolt" to contain magic values

2018-01-05 Thread Stephen Boyd
On 12/29, Viresh Kumar wrote: > On 28-12-17, 16:32, Stephen Boyd wrote: > > On 12/28, Viresh Kumar wrote: > > > > So what we need now is: > > > > > > - Stephen to start responding and clarify all the doubts he had as being > > > silent > > > isn't helping. > > > > What can I reply to specific

Re: [PATCH V8 3/3] OPP: Allow "opp-hz" and "opp-microvolt" to contain magic values

2018-01-01 Thread Viresh Kumar
On 02-01-18, 11:35, Rajendra Nayak wrote: > I would want to reiterate what I have been saying for a while, that for these > patches > to be usable on any qualcomm platform completely we need support to associate > multiple power-domains to a single device which is missing today. Sure, but I had t

Re: [PATCH V8 3/3] OPP: Allow "opp-hz" and "opp-microvolt" to contain magic values

2018-01-01 Thread Rajendra Nayak
On 12/28/2017 10:07 AM, Viresh Kumar wrote: > On 27-12-17, 15:54, Rob Herring wrote: >> On Wed, Dec 27, 2017 at 2:56 AM, Viresh Kumar >> wrote: >>> On 26-12-17, 14:29, Rob Herring wrote: On Mon, Dec 18, 2017 at 03:51:30PM +0530, Viresh Kumar wrote: >>> > +On some platforms the exact fr

Re: [PATCH V8 3/3] OPP: Allow "opp-hz" and "opp-microvolt" to contain magic values

2017-12-28 Thread Viresh Kumar
On 28-12-17, 16:32, Stephen Boyd wrote: > On 12/28, Viresh Kumar wrote: > > So what we need now is: > > > > - Stephen to start responding and clarify all the doubts he had as being > > silent > > isn't helping. > > What can I reply to specifically? I explained in detail how this stuff is goi

Re: [PATCH V8 3/3] OPP: Allow "opp-hz" and "opp-microvolt" to contain magic values

2017-12-28 Thread Stephen Boyd
On 12/28, Viresh Kumar wrote: > On 27-12-17, 15:54, Rob Herring wrote: > > > > I don't really know. I don't really care either. I'll probably go > > along with what everyone agrees to, but the only one I see any > > agreement from is Ulf. Also, it is pretty vague as to what platforms > > will use

Re: [PATCH V8 3/3] OPP: Allow "opp-hz" and "opp-microvolt" to contain magic values

2017-12-27 Thread Viresh Kumar
On 27-12-17, 15:54, Rob Herring wrote: > On Wed, Dec 27, 2017 at 2:56 AM, Viresh Kumar wrote: > > On 26-12-17, 14:29, Rob Herring wrote: > >> On Mon, Dec 18, 2017 at 03:51:30PM +0530, Viresh Kumar wrote: > > > >> > +On some platforms the exact frequency or voltage may be hidden from the > >> > OS

Re: [PATCH V8 3/3] OPP: Allow "opp-hz" and "opp-microvolt" to contain magic values

2017-12-27 Thread Rob Herring
On Wed, Dec 27, 2017 at 2:56 AM, Viresh Kumar wrote: > On 26-12-17, 14:29, Rob Herring wrote: >> On Mon, Dec 18, 2017 at 03:51:30PM +0530, Viresh Kumar wrote: > >> > +On some platforms the exact frequency or voltage may be hidden from the >> > OS by >> > +the firmware and the "opp-hz" or the "opp

Re: [PATCH V8 3/3] OPP: Allow "opp-hz" and "opp-microvolt" to contain magic values

2017-12-27 Thread Viresh Kumar
On 26-12-17, 14:29, Rob Herring wrote: > On Mon, Dec 18, 2017 at 03:51:30PM +0530, Viresh Kumar wrote: > > +On some platforms the exact frequency or voltage may be hidden from the OS > > by > > +the firmware and the "opp-hz" or the "opp-microvolt" properties may contain > > +magic values that rep

Re: [PATCH V8 3/3] OPP: Allow "opp-hz" and "opp-microvolt" to contain magic values

2017-12-26 Thread Rob Herring
On Mon, Dec 18, 2017 at 03:51:30PM +0530, Viresh Kumar wrote: > On some platforms the exact frequency or voltage may be hidden from the > OS by the firmware. Allow such configurations to pass magic values in > the "opp-hz" or the "opp-microvolt" properties, which should be > interpreted in a platfo

[PATCH V8 3/3] OPP: Allow "opp-hz" and "opp-microvolt" to contain magic values

2017-12-18 Thread Viresh Kumar
On some platforms the exact frequency or voltage may be hidden from the OS by the firmware. Allow such configurations to pass magic values in the "opp-hz" or the "opp-microvolt" properties, which should be interpreted in a platform dependent way. Reviewed-by: Ulf Hansson Signed-off-by: Viresh Kum