Re: [PATCH V8 1/5] dma-mapping: Rework dma_get_cache_alignment()

2017-10-19 Thread Christoph Hellwig
On Wed, Oct 18, 2017 at 10:23:36AM -0700, Mark Greer wrote: > > #defineMPSC_RXR_ENTRIES32 > > -#defineMPSC_RXRE_SIZE dma_get_cache_alignment() > > +#defineMPSC_RXRE_SIZE dma_get_cache_alignment(dma_dev) > > I would much prefer that you add a parameter to the

Re: [PATCH V8 1/5] dma-mapping: Rework dma_get_cache_alignment()

2017-10-18 Thread Mark Greer
On Tue, Oct 17, 2017 at 04:05:38PM +0800, Huacai Chen wrote: > Make dma_get_cache_alignment() to accept a 'dev' argument. As a result, > it can return different alignments due to different devices' I/O cache > coherency. > > Currently, ARM/ARM64 and MIPS support coherent & noncoherent devices > co

[PATCH V8 1/5] dma-mapping: Rework dma_get_cache_alignment()

2017-10-17 Thread Huacai Chen
Make dma_get_cache_alignment() to accept a 'dev' argument. As a result, it can return different alignments due to different devices' I/O cache coherency. Currently, ARM/ARM64 and MIPS support coherent & noncoherent devices co-exist. This may be extended in the future, so add a new function pointer