Re: [PATCH V8 1/1] i2c: i2c-qcom-geni: Add shutdown callback for i2c

2021-04-20 Thread rojay
Hi Stephen, On 2021-02-24 12:36, Stephen Boyd wrote: Quoting ro...@codeaurora.org (2021-02-18 06:15:17) Hi Stephen, On 2021-01-13 12:24, Stephen Boyd wrote: > Quoting Roja Rani Yarubandi (2021-01-08 07:05:45) >> diff --git a/drivers/i2c/busses/i2c-qcom-geni.c >> b/drivers/i2c/busses/i2c-qcom-g

Re: [PATCH V8 1/1] i2c: i2c-qcom-geni: Add shutdown callback for i2c

2021-02-24 Thread Wolfram Sang
> BTW, I see this is merged upstream. That's great, but it seems broken. > Please fix it or revert it out. Sorry, that was my mistake! I was aware of this discussion. It seems I accidently applied it. I'll send a revert and we can reapply it once everyone is happy. signature.asc Description: P

Re: [PATCH V8 1/1] i2c: i2c-qcom-geni: Add shutdown callback for i2c

2021-02-23 Thread Stephen Boyd
Quoting ro...@codeaurora.org (2021-02-18 06:15:17) > Hi Stephen, > > On 2021-01-13 12:24, Stephen Boyd wrote: > > Quoting Roja Rani Yarubandi (2021-01-08 07:05:45) > >> diff --git a/drivers/i2c/busses/i2c-qcom-geni.c > >> b/drivers/i2c/busses/i2c-qcom-geni.c > >> index 214b4c913a13..c3f584795911

Re: [PATCH V8 1/1] i2c: i2c-qcom-geni: Add shutdown callback for i2c

2021-02-18 Thread rojay
Hi Stephen, On 2021-01-13 12:24, Stephen Boyd wrote: Quoting Roja Rani Yarubandi (2021-01-08 07:05:45) diff --git a/drivers/i2c/busses/i2c-qcom-geni.c b/drivers/i2c/busses/i2c-qcom-geni.c index 214b4c913a13..c3f584795911 100644 --- a/drivers/i2c/busses/i2c-qcom-geni.c +++ b/drivers/i2c/busses/

Re: [PATCH V8 1/1] i2c: i2c-qcom-geni: Add shutdown callback for i2c

2021-01-12 Thread Stephen Boyd
Quoting Roja Rani Yarubandi (2021-01-08 07:05:45) > diff --git a/drivers/i2c/busses/i2c-qcom-geni.c > b/drivers/i2c/busses/i2c-qcom-geni.c > index 214b4c913a13..c3f584795911 100644 > --- a/drivers/i2c/busses/i2c-qcom-geni.c > +++ b/drivers/i2c/busses/i2c-qcom-geni.c > @@ -375,6 +375,32 @@ static v

Re: [PATCH V8 1/1] i2c: i2c-qcom-geni: Add shutdown callback for i2c

2021-01-11 Thread Akash Asthana
On 1/8/2021 8:35 PM, Roja Rani Yarubandi wrote: If the hardware is still accessing memory after SMMU translation is disabled (as part of smmu shutdown callback), then the IOVAs (I/O virtual address) which it was using will go on the bus as the physical addresses which will result in unknown cra

[PATCH V8 1/1] i2c: i2c-qcom-geni: Add shutdown callback for i2c

2021-01-08 Thread Roja Rani Yarubandi
If the hardware is still accessing memory after SMMU translation is disabled (as part of smmu shutdown callback), then the IOVAs (I/O virtual address) which it was using will go on the bus as the physical addresses which will result in unknown crashes like NoC/interconnect errors. So, implement sh