> > The use of 'goto' is not needed here IMHO. I think:
...
> In context to the previous comment [1], I have implemented this way.
> But, yeah anything is fine for me.
Thanks, I really think it is better.
> In geni_i2c_abort_xfer() function gi2c->cur will be made NULL, so copying it
> before to
Hi Wolfram,
On 2021-01-05 20:57, Wolfram Sang wrote:
+ geni_status = readl_relaxed(gi2c->se.base + SE_GENI_STATUS);
+ if (!(geni_status & M_GENI_CMD_ACTIVE))
+ goto out;
+
+ cur = gi2c->cur;
+ geni_i2c_abort_xfer(gi2c);
+ if (cur->flags & I2C_M_RD)
+
> + geni_status = readl_relaxed(gi2c->se.base + SE_GENI_STATUS);
> + if (!(geni_status & M_GENI_CMD_ACTIVE))
> + goto out;
> +
> + cur = gi2c->cur;
> + geni_i2c_abort_xfer(gi2c);
> + if (cur->flags & I2C_M_RD)
> + geni_i2c_rx_msg_cleanup(gi2c, cur);
> +
On 12/21/2020 6:08 PM, Roja Rani Yarubandi wrote:
If the hardware is still accessing memory after SMMU translation
is disabled (as part of smmu shutdown callback), then the
IOVAs (I/O virtual address) which it was using will go on the bus
as the physical addresses which will result in unknown c
If the hardware is still accessing memory after SMMU translation
is disabled (as part of smmu shutdown callback), then the
IOVAs (I/O virtual address) which it was using will go on the bus
as the physical addresses which will result in unknown crashes
like NoC/interconnect errors.
So, implement sh
5 matches
Mail list logo
