Re: [PATCH V6 2/3] dma: add Qualcomm Technologies HIDMA management driver

2015-11-22 Thread Sinan Kaya
>>> >>> Can it be like >>> >>> /sys/…/DEVICExx/ >>> channelYY/ >>> attr1 >>> attr2 >>> … >>> >>> ? >> >> I'll work on it. I didn't know that you are allowed to create subdirectories >> in sysfs. I was just creating attributes to keep it simple. But, your >> suggestion is cleaner. >> >>> >>> I t

Re: [PATCH V6 2/3] dma: add Qualcomm Technologies HIDMA management driver

2015-11-22 Thread Andy Shevchenko
On Sun, Nov 22, 2015 at 9:52 PM, wrote: >> On Sun, Nov 22, 2015 at 6:37 PM, Sinan Kaya wrote: [] >>> + if (!is_power_of_2(mgmtdev->max_write_request) || >>> + (mgmtdev->max_write_request < 128) || >> >> Someone likes parens. > > yes, I do. I don't trust compilers and also d

Re: [PATCH V6 2/3] dma: add Qualcomm Technologies HIDMA management driver

2015-11-22 Thread okaya
> On Sun, Nov 22, 2015 at 6:37 PM, Sinan Kaya wrote: >> The Qualcomm Technologies HIDMA device has been designed >> to support virtualization technology. The driver has been >> divided into two to follow the hardware design. >> >> 1. HIDMA Management driver >> 2. HIDMA Channel driver >> >> Each HI

Re: [PATCH V6 2/3] dma: add Qualcomm Technologies HIDMA management driver

2015-11-22 Thread Andy Shevchenko
On Sun, Nov 22, 2015 at 6:37 PM, Sinan Kaya wrote: > The Qualcomm Technologies HIDMA device has been designed > to support virtualization technology. The driver has been > divided into two to follow the hardware design. > > 1. HIDMA Management driver > 2. HIDMA Channel driver > > Each HIDMA HW con

[PATCH V6 2/3] dma: add Qualcomm Technologies HIDMA management driver

2015-11-22 Thread Sinan Kaya
The Qualcomm Technologies HIDMA device has been designed to support virtualization technology. The driver has been divided into two to follow the hardware design. 1. HIDMA Management driver 2. HIDMA Channel driver Each HIDMA HW consists of multiple channels. These channels share some set of commo