Re: [PATCH V5 1/2] watchdog: Use static struct class watchdog_class in stead of pointer

2015-12-21 Thread Pratyush Anand
On 21/12/2015:07:52:59 AM, Guenter Roeck wrote: > On 12/18/2015 08:22 PM, Pratyush Anand wrote: > >On 17/12/2015:06:56:27 AM, Guenter Roeck wrote: > >>On 12/17/2015 04:23 AM, Pratyush Anand wrote: > >>>We need few sysfs attributes to know different status of a watchdog device. > >>>To do that, we n

Re: [PATCH V5 1/2] watchdog: Use static struct class watchdog_class in stead of pointer

2015-12-21 Thread Guenter Roeck
On 12/18/2015 08:22 PM, Pratyush Anand wrote: On 17/12/2015:06:56:27 AM, Guenter Roeck wrote: On 12/17/2015 04:23 AM, Pratyush Anand wrote: We need few sysfs attributes to know different status of a watchdog device. To do that, we need to associate .dev_groups with watchdog_class. So convert it

Re: [PATCH V5 1/2] watchdog: Use static struct class watchdog_class in stead of pointer

2015-12-19 Thread Guenter Roeck
On 12/18/2015 08:22 PM, Pratyush Anand wrote: On 17/12/2015:06:56:27 AM, Guenter Roeck wrote: On 12/17/2015 04:23 AM, Pratyush Anand wrote: We need few sysfs attributes to know different status of a watchdog device. To do that, we need to associate .dev_groups with watchdog_class. So convert it

Re: [PATCH V5 1/2] watchdog: Use static struct class watchdog_class in stead of pointer

2015-12-18 Thread Pratyush Anand
On 17/12/2015:06:56:27 AM, Guenter Roeck wrote: > On 12/17/2015 04:23 AM, Pratyush Anand wrote: > >We need few sysfs attributes to know different status of a watchdog device. > >To do that, we need to associate .dev_groups with watchdog_class. So > >convert it from pointer to static. > >Putting thi

Re: [PATCH V5 1/2] watchdog: Use static struct class watchdog_class in stead of pointer

2015-12-17 Thread Guenter Roeck
On 12/17/2015 04:23 AM, Pratyush Anand wrote: We need few sysfs attributes to know different status of a watchdog device. To do that, we need to associate .dev_groups with watchdog_class. So convert it from pointer to static. Putting this static struct in watchdog_dev.c, so that static device att

[PATCH V5 1/2] watchdog: Use static struct class watchdog_class in stead of pointer

2015-12-17 Thread Pratyush Anand
We need few sysfs attributes to know different status of a watchdog device. To do that, we need to associate .dev_groups with watchdog_class. So convert it from pointer to static. Putting this static struct in watchdog_dev.c, so that static device attributes defined in that file can be attached to