Re: [PATCH V5 07/11] of: Add bindings of hw-trip-points for soctherm

2016-02-17 Thread Matt Longnecker
(cc += linux-pm) Rob, The Linux thermal framework makes a sharp distinction between "thermal zones" and "cooling devices". thermal_zones are aware of temperatures and have trip points. cooling_devices are unaware of temperatures -- they just have a state variable. The thermal framework binds

Re: [PATCH V5 07/11] of: Add bindings of hw-trip-points for soctherm

2016-02-17 Thread Wei Ni
Hi, Rob On 2016年02月15日 15:15, Wei Ni wrote: > Hi, Rob > > On 2016年02月12日 22:42, Rob Herring wrote: >> On Fri, Jan 29, 2016 at 2:47 AM, Wei Ni wrote: >>> Add hw-trips sub-node for soctherm, which is >>> used to describe the hardware trip points for >>> each soctherm sensors. >> >> I still don't u

Re: [PATCH V5 07/11] of: Add bindings of hw-trip-points for soctherm

2016-02-14 Thread Wei Ni
On 2016年02月15日 15:15, Wei Ni wrote: > Hi, Rob > > On 2016年02月12日 22:42, Rob Herring wrote: >> On Fri, Jan 29, 2016 at 2:47 AM, Wei Ni wrote: >>> Add hw-trips sub-node for soctherm, which is >>> used to describe the hardware trip points for >>> each soctherm sensors. >> >> I still don't understa

Re: [PATCH V5 07/11] of: Add bindings of hw-trip-points for soctherm

2016-02-14 Thread Wei Ni
Hi, Rob On 2016年02月12日 22:42, Rob Herring wrote: > On Fri, Jan 29, 2016 at 2:47 AM, Wei Ni wrote: >> Add hw-trips sub-node for soctherm, which is >> used to describe the hardware trip points for >> each soctherm sensors. > > I still don't understand why you are doing something custom here. > Wha

Re: [PATCH V5 07/11] of: Add bindings of hw-trip-points for soctherm

2016-02-12 Thread Rob Herring
On Fri, Jan 29, 2016 at 2:47 AM, Wei Ni wrote: > Add hw-trips sub-node for soctherm, which is > used to describe the hardware trip points for > each soctherm sensors. I still don't understand why you are doing something custom here. What's wrong with what is defined in: Documentation/devicetree/

[PATCH V5 07/11] of: Add bindings of hw-trip-points for soctherm

2016-01-29 Thread Wei Ni
Add hw-trips sub-node for soctherm, which is used to describe the hardware trip points for each soctherm sensors. Signed-off-by: Wei Ni --- .../devicetree/bindings/thermal/tegra-soctherm.txt | 24 ++ 1 file changed, 24 insertions(+) diff --git a/Documentation/devicetree/bind