Re: [PATCH V4 4/7] PCI: Unify try slot and bus reset API

2018-07-02 Thread Sinan Kaya
On 6/29/2018 5:43 PM, Andy Shevchenko wrote: >> +int pci_try_reset_bus(struct pci_dev *pdev) >> +{ >> + bool slot = false; >> + >> + if (!pci_probe_reset_slot(pdev->slot)) >> + slot = true; >> + >> + return slot ? __pci_try_reset_slot(pdev->slot) : >> +

Re: [PATCH V4 4/7] PCI: Unify try slot and bus reset API

2018-06-29 Thread Andy Shevchenko
On Thu, Jun 28, 2018 at 10:31 PM, Sinan Kaya wrote: > Drivers are expected to call pci_try_reset_slot() or pci_try_reset_bus() by > querying if a system supports hotplug or not. A survey showed that most > drivers don't do this and we are leaking hotplug capability to the user. > > Hide pci_try_sl

[PATCH V4 4/7] PCI: Unify try slot and bus reset API

2018-06-28 Thread Sinan Kaya
Drivers are expected to call pci_try_reset_slot() or pci_try_reset_bus() by querying if a system supports hotplug or not. A survey showed that most drivers don't do this and we are leaking hotplug capability to the user. Hide pci_try_slot_reset() from drivers and embed into pci_try_bus_reset(). Ch