RE: [PATCH V4 2/5] input: keyboard: imx_sc: Add i.MX system controller key support

2019-09-22 Thread Anson Huang
Hi, Pavel > Subject: Re: [PATCH V4 2/5] input: keyboard: imx_sc: Add i.MX system > controller key support > > Hi! > > > > > + ret = imx_scu_call_rpc(priv->key_ipc_handle, &msg, true); > > > > + if (ret) { > > > > +

Re: [PATCH V4 2/5] input: keyboard: imx_sc: Add i.MX system controller key support

2019-09-22 Thread Pavel Machek
Hi! > > > + ret = imx_scu_call_rpc(priv->key_ipc_handle, &msg, true); > > > + if (ret) { > > > + dev_err(&input->dev, "read imx sc key failed, ret %d\n", ret); > > > + return; > > > + } > > > + > > > + state = (bool)msg.state; > > > + > > > + if (!state && !priv->keystate) > > > +

RE: [PATCH V4 2/5] input: keyboard: imx_sc: Add i.MX system controller key support

2019-09-16 Thread Anson Huang
Hi, Dmitry > On Mon, Sep 16, 2019 at 10:52:50AM +0800, Anson Huang wrote: > > i.MX8QXP is an ARMv8 SoC which has a Cortex-M4 system controller > > inside, the system controller is in charge of controlling power, clock > > and scu key etc.. > > > > Adds i.MX system controller key driver support, Li

Re: [PATCH V4 2/5] input: keyboard: imx_sc: Add i.MX system controller key support

2019-09-16 Thread Dmitry Torokhov
On Mon, Sep 16, 2019 at 10:52:50AM +0800, Anson Huang wrote: > i.MX8QXP is an ARMv8 SoC which has a Cortex-M4 system controller > inside, the system controller is in charge of controlling power, > clock and scu key etc.. > > Adds i.MX system controller key driver support, Linux kernel has > to com

[PATCH V4 2/5] input: keyboard: imx_sc: Add i.MX system controller key support

2019-09-15 Thread Anson Huang
i.MX8QXP is an ARMv8 SoC which has a Cortex-M4 system controller inside, the system controller is in charge of controlling power, clock and scu key etc.. Adds i.MX system controller key driver support, Linux kernel has to communicate with system controller via MU (message unit) IPC to get scu key'