Re: [PATCH V4 1/4] mm: set page->pfmemalloc in prep_new_page()

2015-01-07 Thread Michal Hocko
On Wed 07-01-15 10:36:58, Vlastimil Babka wrote: > On 01/06/2015 10:44 PM, Michal Hocko wrote: > > On Tue 06-01-15 22:10:55, Vlastimil Babka wrote: > >> On 01/06/2015 03:30 PM, Michal Hocko wrote: > > [...] > >> > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > >> > index 1bb65e6f48dd..1682d766cb8

Re: [PATCH V4 1/4] mm: set page->pfmemalloc in prep_new_page()

2015-01-07 Thread Vlastimil Babka
On 01/06/2015 10:44 PM, Michal Hocko wrote: > On Tue 06-01-15 22:10:55, Vlastimil Babka wrote: >> On 01/06/2015 03:30 PM, Michal Hocko wrote: > [...] >> > diff --git a/mm/page_alloc.c b/mm/page_alloc.c >> > index 1bb65e6f48dd..1682d766cb8e 100644 >> > --- a/mm/page_alloc.c >> > +++ b/mm/page_alloc.

Re: [PATCH V4 1/4] mm: set page->pfmemalloc in prep_new_page()

2015-01-06 Thread Michal Hocko
On Tue 06-01-15 22:10:55, Vlastimil Babka wrote: > On 01/06/2015 03:30 PM, Michal Hocko wrote: [...] > > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > > index 1bb65e6f48dd..1682d766cb8e 100644 > > --- a/mm/page_alloc.c > > +++ b/mm/page_alloc.c > > @@ -2175,10 +2175,11 @@ zonelist_scan: > >

Re: [PATCH V4 1/4] mm: set page->pfmemalloc in prep_new_page()

2015-01-06 Thread Vlastimil Babka
On 01/06/2015 03:30 PM, Michal Hocko wrote: > On Mon 05-01-15 18:17:40, Vlastimil Babka wrote: >> The function prep_new_page() sets almost everything in the struct page of the >> page being allocated, except page->pfmemalloc. This is not obvious and has at >> least once led to a bug where page->pfm

Re: [PATCH V4 1/4] mm: set page->pfmemalloc in prep_new_page()

2015-01-06 Thread Michal Hocko
On Mon 05-01-15 18:17:40, Vlastimil Babka wrote: > The function prep_new_page() sets almost everything in the struct page of the > page being allocated, except page->pfmemalloc. This is not obvious and has at > least once led to a bug where page->pfmemalloc was forgotten to be set > correctly, see

[PATCH V4 1/4] mm: set page->pfmemalloc in prep_new_page()

2015-01-05 Thread Vlastimil Babka
The function prep_new_page() sets almost everything in the struct page of the page being allocated, except page->pfmemalloc. This is not obvious and has at least once led to a bug where page->pfmemalloc was forgotten to be set correctly, see commit 8fb74b9fb2b1 ("mm: compaction: partially revert ca