Re: [PATCH V4 1/3] virtio: don't prompt CONFIG_VIRTIO_PCI_MODERN

2021-02-24 Thread Christian Borntraeger
On 23.02.21 07:19, Jason Wang wrote: > We used to prompt CONFIG_VIRTIO_PCI_MODERN to user which may bring a > lot of confusion. E.g it may break various default configs which want > virtio devices. > > So this patch fixes this by hiding the prompot and documenting the > dependency. While at it,

Re: [PATCH V4 1/3] virtio: don't prompt CONFIG_VIRTIO_PCI_MODERN

2021-02-23 Thread Michael S. Tsirkin
On Tue, Feb 23, 2021 at 09:50:35AM -0600, Daniel Díaz wrote: > Hello! > > If I may add to the nit-picking... > > On Tue, 23 Feb 2021 at 09:23, Guenter Roeck wrote: > > On 2/22/21 10:19 PM, Jason Wang wrote: > > > We used to prompt CONFIG_VIRTIO_PCI_MODERN to user which may bring a > > > lot of c

Re: [PATCH V4 1/3] virtio: don't prompt CONFIG_VIRTIO_PCI_MODERN

2021-02-23 Thread Daniel Díaz
Hello! If I may add to the nit-picking... On Tue, 23 Feb 2021 at 09:23, Guenter Roeck wrote: > On 2/22/21 10:19 PM, Jason Wang wrote: > > We used to prompt CONFIG_VIRTIO_PCI_MODERN to user which may bring a > > lot of confusion. E.g it may break various default configs which want > > virtio devi

Re: [PATCH V4 1/3] virtio: don't prompt CONFIG_VIRTIO_PCI_MODERN

2021-02-23 Thread Guenter Roeck
On 2/22/21 10:19 PM, Jason Wang wrote: > We used to prompt CONFIG_VIRTIO_PCI_MODERN to user which may bring a > lot of confusion. E.g it may break various default configs which want > virtio devices. > > So this patch fixes this by hiding the prompot and documenting the > dependency. While at it,

Re: [PATCH V4 1/3] virtio: don't prompt CONFIG_VIRTIO_PCI_MODERN

2021-02-23 Thread Arnd Bergmann
On Tue, Feb 23, 2021 at 7:19 AM Jason Wang wrote: > > We used to prompt CONFIG_VIRTIO_PCI_MODERN to user which may bring a > lot of confusion. E.g it may break various default configs which want > virtio devices. > > So this patch fixes this by hiding the prompot and documenting the > dependency.

[PATCH V4 1/3] virtio: don't prompt CONFIG_VIRTIO_PCI_MODERN

2021-02-22 Thread Jason Wang
We used to prompt CONFIG_VIRTIO_PCI_MODERN to user which may bring a lot of confusion. E.g it may break various default configs which want virtio devices. So this patch fixes this by hiding the prompot and documenting the dependency. While at it, rename the module to VIRTIO_PCI_LIB. Cc: Arnd Berg