Re: [PATCH V4 1/2] PCI: dwc: Add API support to de-initialize host

2019-06-20 Thread Vidya Sagar
On 6/20/2019 10:22 PM, Lorenzo Pieralisi wrote: On Wed, Jun 19, 2019 at 10:41:26AM +0530, Kishon Vijay Abraham I wrote: Hi Lorenzo, On 18/06/19 7:58 PM, Lorenzo Pieralisi wrote: On Tue, Jun 18, 2019 at 04:21:17PM +0530, Vidya Sagar wrote: [...] 2) It is not related to this patch but I fail

Re: [PATCH V4 1/2] PCI: dwc: Add API support to de-initialize host

2019-06-20 Thread Lorenzo Pieralisi
On Wed, Jun 19, 2019 at 10:41:26AM +0530, Kishon Vijay Abraham I wrote: > Hi Lorenzo, > > On 18/06/19 7:58 PM, Lorenzo Pieralisi wrote: > > On Tue, Jun 18, 2019 at 04:21:17PM +0530, Vidya Sagar wrote: > > > > [...] > > > >>> 2) It is not related to this patch but I fail to see the reasoning > >>

Re: [PATCH V4 1/2] PCI: dwc: Add API support to de-initialize host

2019-06-18 Thread Kishon Vijay Abraham I
Hi Lorenzo, On 18/06/19 7:58 PM, Lorenzo Pieralisi wrote: > On Tue, Jun 18, 2019 at 04:21:17PM +0530, Vidya Sagar wrote: > > [...] > >>> 2) It is not related to this patch but I fail to see the reasoning >>> behind the __ in __dw_pci_read_dbi(), there is no no-underscore >>> equivalent s

Re: [PATCH V4 1/2] PCI: dwc: Add API support to de-initialize host

2019-06-18 Thread Lorenzo Pieralisi
On Tue, Jun 18, 2019 at 04:21:17PM +0530, Vidya Sagar wrote: [...] > > 2) It is not related to this patch but I fail to see the reasoning > > behind the __ in __dw_pci_read_dbi(), there is no no-underscore > > equivalent so its definition is somewhat questionable, maybe > > we should

Re: [PATCH V4 1/2] PCI: dwc: Add API support to de-initialize host

2019-06-18 Thread Vidya Sagar
On 6/18/2019 3:06 PM, Lorenzo Pieralisi wrote: On Tue, Jun 18, 2019 at 10:19:14AM +0530, Vidya Sagar wrote: [...] Sorry for pinging again. Please let me know if these patches need to be sent again. No problem. We can merge the code as-is even though I have a couple of questions. 1) What abo

Re: [PATCH V4 1/2] PCI: dwc: Add API support to de-initialize host

2019-06-18 Thread Lorenzo Pieralisi
On Tue, Jun 18, 2019 at 10:19:14AM +0530, Vidya Sagar wrote: [...] > Sorry for pinging again. Please let me know if these patches need to > be sent again. No problem. We can merge the code as-is even though I have a couple of questions. 1) What about dbi2 interfaces (what an horrible name it is

Re: [PATCH V4 1/2] PCI: dwc: Add API support to de-initialize host

2019-06-17 Thread Vidya Sagar
On 6/13/2019 11:54 PM, Vidya Sagar wrote: On 6/7/2019 6:43 PM, Vidya Sagar wrote: On 5/27/2019 4:39 PM, Vidya Sagar wrote: On 5/7/2019 12:25 PM, Vidya Sagar wrote: On 5/7/2019 11:19 AM, Vidya Sagar wrote: On 5/3/2019 4:53 PM, Lorenzo Pieralisi wrote: On Thu, May 02, 2019 at 10:34:25PM +0530,

Re: [PATCH V4 1/2] PCI: dwc: Add API support to de-initialize host

2019-06-13 Thread Vidya Sagar
On 6/7/2019 6:43 PM, Vidya Sagar wrote: On 5/27/2019 4:39 PM, Vidya Sagar wrote: On 5/7/2019 12:25 PM, Vidya Sagar wrote: On 5/7/2019 11:19 AM, Vidya Sagar wrote: On 5/3/2019 4:53 PM, Lorenzo Pieralisi wrote: On Thu, May 02, 2019 at 10:34:25PM +0530, Vidya Sagar wrote: Add an API to group al

Re: [PATCH V4 1/2] PCI: dwc: Add API support to de-initialize host

2019-06-07 Thread Vidya Sagar
On 5/27/2019 4:39 PM, Vidya Sagar wrote: On 5/7/2019 12:25 PM, Vidya Sagar wrote: On 5/7/2019 11:19 AM, Vidya Sagar wrote: On 5/3/2019 4:53 PM, Lorenzo Pieralisi wrote: On Thu, May 02, 2019 at 10:34:25PM +0530, Vidya Sagar wrote: Add an API to group all the tasks to be done to de-initialize h

Re: [PATCH V4 1/2] PCI: dwc: Add API support to de-initialize host

2019-05-27 Thread Vidya Sagar
On 5/7/2019 12:25 PM, Vidya Sagar wrote: On 5/7/2019 11:19 AM, Vidya Sagar wrote: On 5/3/2019 4:53 PM, Lorenzo Pieralisi wrote: On Thu, May 02, 2019 at 10:34:25PM +0530, Vidya Sagar wrote: Add an API to group all the tasks to be done to de-initialize host which can then be called by any Design

Re: [PATCH V4 1/2] PCI: dwc: Add API support to de-initialize host

2019-05-06 Thread Vidya Sagar
On 5/7/2019 11:19 AM, Vidya Sagar wrote: On 5/3/2019 4:53 PM, Lorenzo Pieralisi wrote: On Thu, May 02, 2019 at 10:34:25PM +0530, Vidya Sagar wrote: Add an API to group all the tasks to be done to de-initialize host which can then be called by any DesignWare core based driver implementations whi

Re: [PATCH V4 1/2] PCI: dwc: Add API support to de-initialize host

2019-05-06 Thread Vidya Sagar
On 5/3/2019 4:53 PM, Lorenzo Pieralisi wrote: On Thu, May 02, 2019 at 10:34:25PM +0530, Vidya Sagar wrote: Add an API to group all the tasks to be done to de-initialize host which can then be called by any DesignWare core based driver implementations while adding .remove() support in their respe

Re: [PATCH V4 1/2] PCI: dwc: Add API support to de-initialize host

2019-05-03 Thread Lorenzo Pieralisi
On Thu, May 02, 2019 at 10:34:25PM +0530, Vidya Sagar wrote: > Add an API to group all the tasks to be done to de-initialize host which > can then be called by any DesignWare core based driver implementations > while adding .remove() support in their respective drivers. > > Signed-off-by: Vidya Sa

[PATCH V4 1/2] PCI: dwc: Add API support to de-initialize host

2019-05-02 Thread Vidya Sagar
Add an API to group all the tasks to be done to de-initialize host which can then be called by any DesignWare core based driver implementations while adding .remove() support in their respective drivers. Signed-off-by: Vidya Sagar Acked-by: Gustavo Pimentel --- Changes from v3: * Added check if