Re: [PATCH V3 4/5] cpufreq: Register notifiers with the PM QoS framework

2019-06-19 Thread Rafael J. Wysocki
On Wed, Jun 19, 2019 at 8:39 AM Viresh Kumar wrote: > > On 19-06-19, 00:23, Rafael J. Wysocki wrote: > > In patch [3/5] you could point notifiers for both min and max freq to the > > same > > notifier head. Both of your notifiers end up calling > > cpufreq_update_policy() > > anyway. > > I tri

Re: [PATCH V3 4/5] cpufreq: Register notifiers with the PM QoS framework

2019-06-18 Thread Viresh Kumar
On 19-06-19, 00:23, Rafael J. Wysocki wrote: > In patch [3/5] you could point notifiers for both min and max freq to the same > notifier head. Both of your notifiers end up calling cpufreq_update_policy() > anyway. I tried it and the changes in qos.c file look fine. But I don't like at all how c

Re: [PATCH V3 4/5] cpufreq: Register notifiers with the PM QoS framework

2019-06-18 Thread Rafael J. Wysocki
On Tuesday, June 18, 2019 1:25:22 PM CEST Viresh Kumar wrote: > On 18-06-19, 01:26, Rafael J. Wysocki wrote: > > On Monday, June 10, 2019 12:51:35 PM CEST Viresh Kumar wrote: > > > +static int cpufreq_notifier_min(struct notifier_block *nb, unsigned long > > > freq, > > > +

Re: [PATCH V3 4/5] cpufreq: Register notifiers with the PM QoS framework

2019-06-18 Thread Viresh Kumar
On 18-06-19, 01:37, Rafael J. Wysocki wrote: > One more thing. > > handle_update() is very similar to cpufreq_update_freq_work(). > > Why are both of them needed? I probably did that because of locking required in cpufreq_update_freq_work() but maybe I can do better. Lemme try and come back on i

Re: [PATCH V3 4/5] cpufreq: Register notifiers with the PM QoS framework

2019-06-18 Thread Viresh Kumar
On 18-06-19, 01:26, Rafael J. Wysocki wrote: > On Monday, June 10, 2019 12:51:35 PM CEST Viresh Kumar wrote: > > +static int cpufreq_notifier_min(struct notifier_block *nb, unsigned long > > freq, > > + void *data) > > +{ > > + struct cpufreq_policy *policy = container_

Re: [PATCH V3 4/5] cpufreq: Register notifiers with the PM QoS framework

2019-06-17 Thread Rafael J. Wysocki
On Monday, June 10, 2019 12:51:35 PM CEST Viresh Kumar wrote: > This registers the notifiers for min/max frequency constraints with the > PM QoS framework. The constraints are also taken into consideration in > cpufreq_set_policy(). > > This also relocates cpufreq_policy_put_kobj() as it is requir

Re: [PATCH V3 4/5] cpufreq: Register notifiers with the PM QoS framework

2019-06-17 Thread Rafael J. Wysocki
On Monday, June 10, 2019 12:51:35 PM CEST Viresh Kumar wrote: > This registers the notifiers for min/max frequency constraints with the > PM QoS framework. The constraints are also taken into consideration in > cpufreq_set_policy(). > > This also relocates cpufreq_policy_put_kobj() as it is requir

Re: [PATCH V3 4/5] cpufreq: Register notifiers with the PM QoS framework

2019-06-17 Thread Ulf Hansson
On Mon, 10 Jun 2019 at 12:52, Viresh Kumar wrote: > > This registers the notifiers for min/max frequency constraints with the > PM QoS framework. The constraints are also taken into consideration in > cpufreq_set_policy(). > > This also relocates cpufreq_policy_put_kobj() as it is required to be >

Re: [PATCH V3 4/5] cpufreq: Register notifiers with the PM QoS framework

2019-06-16 Thread Viresh Kumar
On 14-06-19, 09:46, Matthias Kaehlcke wrote: > Hi Viresh, > > On Mon, Jun 10, 2019 at 04:21:35PM +0530, Viresh Kumar wrote: > > This registers the notifiers for min/max frequency constraints with the > > PM QoS framework. The constraints are also taken into consideration in > > cpufreq_set_policy(

Re: [PATCH V3 4/5] cpufreq: Register notifiers with the PM QoS framework

2019-06-14 Thread Matthias Kaehlcke
Hi Viresh, On Mon, Jun 10, 2019 at 04:21:35PM +0530, Viresh Kumar wrote: > This registers the notifiers for min/max frequency constraints with the > PM QoS framework. The constraints are also taken into consideration in > cpufreq_set_policy(). > > This also relocates cpufreq_policy_put_kobj() as

[PATCH V3 4/5] cpufreq: Register notifiers with the PM QoS framework

2019-06-10 Thread Viresh Kumar
This registers the notifiers for min/max frequency constraints with the PM QoS framework. The constraints are also taken into consideration in cpufreq_set_policy(). This also relocates cpufreq_policy_put_kobj() as it is required to be called from cpufreq_policy_alloc() now. No constraints are add