Re: [PATCH V3 3/6] slimbus: Add messaging APIs to slimbus framework

2015-08-14 Thread Mark Brown
On Fri, Aug 14, 2015 at 07:25:25PM +0100, Mark Brown wrote: > On Mon, Aug 03, 2015 at 12:59:47AM -0600, Sagar Dharia wrote: > > + sema_init(&ctrl->tx_sem, (ctrl->tx.n - 1)); > This sempahore counts the number of free slots in the statically > allocated list of transfers we have allocated. It w

Re: [PATCH V3 3/6] slimbus: Add messaging APIs to slimbus framework

2015-08-14 Thread Mark Brown
On Mon, Aug 03, 2015 at 12:59:47AM -0600, Sagar Dharia wrote: > + sema_init(&ctrl->tx_sem, (ctrl->tx.n - 1)); This sempahore counts the number of free slots in the statically allocated list of transfers we have allocated. It would be good to see some discussion in the changelog as to why we'

[PATCH V3 3/6] slimbus: Add messaging APIs to slimbus framework

2015-08-03 Thread Sagar Dharia
Slimbus devices use value-element, and information elements to control device parameters (e.g. value element is used to represent gain for codec, information element is used to represent interrupt status for codec when codec interrupt fires). Messaging APIs are used to set/get these value and infor